Milter-greylist

I have made some patches and a spec file to build rpm for redhat/fedora
linux.
I have tested with RH7.3/9 and FC1/2.

The files are available for anyone interested at :
http://www.saisp.br/ifm/patches/

If possible I want that people on other platforms also try this patch :
http://www.saisp.br/ifm/patches/milter-greylist-Makefile.patch

This patch make possible to install the files on a sandbox, which is
necessary to build the rpm.

Ivan F. Martinez <ml@...> wrote:

> If possible I want that people on other platforms also try this patch :
> http://www.saisp.br/ifm/patches/milter-greylist-Makefile.patch
> 
> This patch make possible to install the files on a sandbox, which is
> necessary to build the rpm.

The patch define a ${DESTDIR} prepended to each path in the Makefile.
I'd like to be sure that no build environement will predefine ${DESTDIR}
and therefore produce a mess.

-- 
Emmanuel Dreyfus
Il y a 10 sortes de personnes dans le monde: ceux qui comprennent 
le binaire et ceux qui ne le comprennent pas.
manu@...

--- In milter-greylist@yahoogroups.com, manu@n... wrote:
> Ivan F. Martinez <ml@i...> wrote:
> 
> > If possible I want that people on other platforms also try this
patch :
> > http://www.saisp.br/ifm/patches/milter-greylist-Makefile.patch
> > 
> > This patch make possible to install the files on a sandbox, which is
> > necessary to build the rpm.
> 
> The patch define a ${DESTDIR} prepended to each path in the Makefile.
> I'd like to be sure that no build environement will predefine ${DESTDIR}
> and therefore produce a mess.

DESTDIR (not INSTALL_DESTDIR!) is de facto standard for exactly the
task of installing into a sandbox.  `automake' always start target
paths with "$(DESTDIR)".

Packagers are used to running
"make install DESTDIR=/var/tmp/<pkgroot>".
At least I am :-)

Eugene

On Sat, 11 Dec 2004 10:01:28 -0000
"egcrosser" <egcrosser@...> wrote:

E> 
E> 
E> --- In milter-greylist@yahoogroups.com, manu@n... wrote:
E> > Ivan F. Martinez <ml@i...> wrote:
E> > 
E> > > If possible I want that people on other platforms also try this
E> patch :
E> > > http://www.saisp.br/ifm/patches/milter-greylist-Makefile.patch
E> > > 
E> > > This patch make possible to install the files on a sandbox, which
E> > > is necessary to build the rpm.
E> > 
E> > The patch define a ${DESTDIR} prepended to each path in the
E> > Makefile. I'd like to be sure that no build environement will
E> > predefine ${DESTDIR} and therefore produce a mess.
E> 
E> DESTDIR (not INSTALL_DESTDIR!) is de facto standard for exactly the
E> task of installing into a sandbox.  `automake' always start target
E> paths with "$(DESTDIR)".
E> 
E> Packagers are used to running
E> "make install DESTDIR=/var/tmp/<pkgroot>".
E> At least I am :-)

I have used first DESTDIR, but after Emmanuel doubts about compatibility
with other platforms I have changed to INSTALL_DESTDIR.
googling about this now I found "DESTDIR" is really used in many
packages. 
I changed the patch back to DESTDIR.

Thanks

--

manu@... writes:

> The patch define a ${DESTDIR} prepended to each path in the Makefile.
> I'd like to be sure that no build environement will predefine ${DESTDIR}
> and therefore produce a mess.

Hi Emmanuel,

$ uname -s
FreeBSD

[cyril@blackbox:~ 13:44:35]
$ grep DESTDIR /usr/ports/Mk/*
/usr/ports/Mk/bsd.port.mk:LOCALBASE?=           ${DESTDIR}/usr/local
/usr/ports/Mk/bsd.port.mk:X11BASE?=             ${DESTDIR}/usr/X11R6
/usr/ports/Mk/bsd.port.mk:LINUXBASE?=           ${DESTDIR}/compat/linux
/usr/ports/Mk/bsd.port.subdir.mk:LOCALBASE?=    ${DESTDIR}/usr/local

If this patch creates havoc, I can use FBSD ports patch to mitigate the
issue.

Ivan F. Martinez <ml@...> wrote:

> I have used first DESTDIR, but after Emmanuel doubts about compatibility
> with other platforms I have changed to INSTALL_DESTDIR.
> googling about this now I found "DESTDIR" is really used in many
> packages. 
> I changed the patch back to DESTDIR.

Heh, I have no strong opinion on it, only doubts.

-- 
Emmanuel Dreyfus
Il y a 10 sortes de personnes dans le monde: ceux qui comprennent 
le binaire et ceux qui ne le comprennent pas.
manu@...

Cyril Guibourg <cg+milter-greylist@...> wrote:

> $ grep DESTDIR /usr/ports/Mk/*
> /usr/ports/Mk/bsd.port.mk:LOCALBASE?=           ${DESTDIR}/usr/local
> /usr/ports/Mk/bsd.port.mk:X11BASE?=             ${DESTDIR}/usr/X11R6
> /usr/ports/Mk/bsd.port.mk:LINUXBASE?=           ${DESTDIR}/compat/linux
> /usr/ports/Mk/bsd.port.subdir.mk:LOCALBASE?=    ${DESTDIR}/usr/local
> 
> If this patch creates havoc, I can use FBSD ports patch to mitigate the
> issue.

But will it create havoc?

-- 
Emmanuel Dreyfus
Il y a 10 sortes de personnes dans le monde: ceux qui comprennent 
le binaire et ceux qui ne le comprennent pas.
manu@...

manu@... writes:

> But will it create havoc?

I don't think so. ;-)