Milter-greylist

On Fri, Apr 08, 2011 at 06:32:28PM +0200, manu@... wrote:
> <attila.bruncsak@...> wrote:
> 
> > So I found the bug.
> > I would be surprised that even one people could use the spamd feature
> > of the current development version (4.3.8) without fixing that issue.
> > There was a double accounting in the variable priv->priv_msgcount
> > which has leaded to incorrect Content-length: field value provided to
> > spamd.
> 
> I checked it in. That is strange, the bug did not exist on the 4.2
> branch.

That line is unchanged since 2006:

	1.220 (manu 29-Jun-09):              memcpy(b->b_lines + priv->priv_buflen, chunk, i);
	1.175 (manu 04-Mar-07):              b->b_lines[linelen] = '\0';
	1.235 (manu 12-Jul-10):              b->b_len = linelen;
	1.175 (manu 04-Mar-07):              priv->priv_buflen = 0;
	1.174 (manu 04-Mar-07): 
	1.154 (manu 16-Jan-07):              TAILQ_INSERT_TAIL(&priv->priv_body, b, b_list);
	1.146 (manu 26-Dec-06): 

	1.146 (manu 26-Dec-06):              priv->priv_msgcount += linelen;
	       ^^^^^^^^^^^^^^
	1.214 (manu 06-Nov-08):      }
	1.214 (manu 06-Nov-08): 
	1.214 (manu 06-Nov-08):      if(i < size) { /* keep the remains for later */
	1.146 (manu 26-Dec-06):              if ((priv->priv_buf = realloc(priv->priv_buf, 

..years before spamd support was added.  Hence, all spamd users have
been running milter-greylist with that line since spamd was imported.

Attila, what SA version are you running?  What does tcpdump say?