Milter-greylist

On Fri, Apr 08, 2011 at 06:20:41PM +0200, manu@... wrote:
> 
> > (For example the queue-id is sent as a user name for spamd.)
> 
> Here is the offending code. Indeed the queud-id is sent as User:
>         snprintf(buffer, SPAMD_BUFLEN,
>           "CHECK SPAMC/1.2\r\n" 
>           "Content-length: %d\r\n"
>           "User: %s\r\n\r\n",
>           (unsigned int)(priv->priv_msgcount + strlen(rcvhdr)),
>            priv->priv_queueid);
> 
> I can change that, but what should be in the User field? Or is it the
> field name that must be changed? I am clueless.


We did that on purpose:

On Mon, May 11, 2009 at 09:55:38AM +0200, Petar Bogdanovic wrote:
> On Mon, May 11, 2009 at 09:35:20AM +0200, Petar Bogdanovic wrote:
> > On Mon, May 11, 2009 at 07:17:39AM +0000, Emmanuel Dreyfus wrote:
> > > On Mon, May 11, 2009 at 09:13:53AM +0200, Petar Bogdanovic wrote:
> > > >         snprintf(buffer, SPAMD_BUFLEN,
> > > > -         "CHECK SPAMC/1.2\r\nContent-length: %d\r\n\r\n",
> > > > -         (unsigned int)(priv->priv_msgcount + strlen(rcvhdr)));
> > > > +         "CHECK SPAMC/1.2\r\n"
> > > > +         "Content-length: %d\r\n"
> > > > +         "User: %s\r\n\r\n",
> > > > +         (unsigned int)(priv->priv_msgcount + strlen(rcvhdr)),
> > > > +          priv->priv_queueid);
> > > 
> > > Is it reasonable to abuse the User field?
> > 
> > I'm not entirely sure (...)
> 
> At least you can't rely on the value of this header since the only thing
> which prevents you from providing a bogus value is a correctly compiled
> spamc or a strict suid-environment which is not an option if spamd is
> listening to an internet socket.