Milter-greylist

John Thiltges <jthiltges2@...> wrote:

> Would it be better to make aclstr[] a larger static buffer and not use
> fstring_expand()?
> 
> Example:
> 
> char aclstr[HDRLEN];
> 
> if (priv->priv_sr.sr_acl_id)
>     snprintf(aclstr, sizeof(aclstr), " (ACL %s)",
>         priv->priv_sr.sr_acl_id);
> else if (priv->priv_sr.sr_acl_line != 0)
>     snprintf(aclstr, sizeof(aclstr), " (ACL %d)",
>         priv->priv_sr.sr_acl_line);
> else
>     aclstr[0] = '\0';

Well, this gets suddently much less readable :-)

-- 
Emmanuel Dreyfus
http://hcpnet.free.fr/pubz
manu@...