Milter-greylist

AIDA Shinra <shinra@...> wrote:

> 1. may_be_forged ACL condition
> http://www.j10n.org/files/milter-greylist-3.0a2-step1.patch
> 
> When a client has bogus reverse DNS, that is, IP -> PTR -> A != IP,
> sendmail sets {client_resolve} macro to FORGED. This patch implements
> ACL condition to take advantage of it. You need to add
> {client_resolve} into Milter.macros.connect. Example:
> acl blacklist domain /.*\.info/ may_be_forged
> acl greylist may_be_forged

Some thoughts:
- may_be_forged name is a bit long to read in ACL. What about just
forged?
- Changes to documentation for the new feature would be nice :-)
- Do you catch a lot of spam with that?

> 2. Threading bug fix
> http://www.j10n.org/files/milter-greylist-3.0a2-step2.patch
> 
> This patch resolvs number of race conditions in threading
> code. It also includes some minor modifications. Since my changes
> affect almost everywhere, code reviews are welcome.

There are huge changes. Could you explain what was wrong?

> 3. Binary search tree
> http://www.j10n.org/files/milter-greylist-3.0a2-step3.patch
> 
> This patch introduces red-black tree structure to manage the greylist
> and autowhitelist. It is just a pedantic change. No realistic
> improvement is expected.

I'm a bit reluctant to make changes that buy nothing. What's the
advantage of adding this?

-- 
Emmanuel Dreyfus
http://hcpnet.free.fr/pubz
manu@...