Yahoo Groups archive

Milter-greylist

Index last updated: 2026-04-28 23:32 UTC

Message

Re: [milter-greylist] milter-greylist patch for DRAC

2005-11-28 by Emmanuel Dreyfus

On Sun, Nov 27, 2005 at 10:51:30PM -0800, Romain Kang wrote:
> I made this patch so that I could send messages out of my PDA using
> "SMTP after POP/IMAP" auth without the greylist delay.  Emmanuel
> Dreyfus suggested sending it to the mailing list for review.
> Perhaps this will be useful to someone else.

Some improvements that would have to be done:

1) Cope with IPv6: Hajimu UMEMOTO proposed a workaround.

2) Add a configure flag to enable USE_DRAC and set the location of the
database. We also need to check for Berkeley DB location. It would be nice
if you could do it, but if you are unfamiliar with autotools and don't have
time to waste, don't worry, I'll do it.

3) When check_drac returns true, don't pass the message immediatly, 
set priv->priv_whitelist = EXF_DRAC instead. Everywhere in the file, 
duplicate the EXF_SPF case and turn it into a EXF_DRAC. This will make
the whitelisting reason appear in the log file and the header.
Again I can do it, but don't hesitate to propose an upgraded patch.

4) As I understand, milter-greylist is only a consumer of the DB 
database. Anotehr process will feed it. What happens if we read while
the other process is writing? Shouldn't we open the file with option
O_SHLOCK to prevent concurent access? Even with O_SHLOCK, there 
might still be a problem if the DB file is on a NFS filesystem, and this
should be documented.

5) Documentation: do we have any? What does DRAC means, BTW?

-- 
Emmanuel Dreyfus
manu@...

Attachments

Move to quarantaine

This moves the raw source file on disk only. The archive index is not changed automatically, so you still need to run a manual refresh afterward.