Milter-greylist

Hi,

>>>>> On Sun, 27 Nov 2005 22:51:30 -0800
>>>>> Romain Kang <romain@...> said:

romain> I made this patch so that I could send messages out of my PDA using
romain> "SMTP after POP/IMAP" auth without the greylist delay.  Emmanuel
romain> Dreyfus suggested sending it to the mailing list for review.
romain> Perhaps this will be useful to someone else.

DRAC doesn't support an IPv6, and it seems your patch doesn't take
care that `addrstr' may hold a string form of an IPv6 address.  So, it
is better to prevent check_drac() from taking an IPv6 address as its
argument, IMHO.

Index: milter-greylist.c
diff -u -p milter-greylist.c.orig milter-greylist.c
--- milter-greylist.c.orig	Mon Nov 28 16:00:36 2005
+++ milter-greylist.c	Mon Nov 28 16:14:12 2005
@@ -300,7 +300,8 @@ mlfi_envrcpt(ctx, envrcpt)
 		    priv->priv_queueid, addrstr, priv->priv_from, *envrcpt);
 
 #ifdef USE_DRAC
-	if (check_drac(addrstr)) {
+	if (SA(&priv->priv_addr)->sa_family == AF_INET &&
+	    check_drac(addrstr)) {
 		if (conf.c_debug)
 			syslog(LOG_DEBUG, "%s found in DRAC", addrstr);
 		return SMFIS_CONTINUE;


Sincerely,

--
Hajimu UMEMOTO @ Internet Mutual Aid Society Yokohama, Japan
ume@...  ume@{,jp.}FreeBSD.org
http://www.imasy.org/~ume/