Milter-greylist

Hi,

>>>>> On Mon, 31 Oct 2005 10:09:27 +0000
>>>>> Emmanuel Dreyfus <manu@...> said:

manu> On Sun, Oct 23, 2005 at 12:33:06AM +0900, Hajimu UMEMOTO wrote:
> I found that a pending entry has a redundant p_addr field which holds
> string form of an IP address.  Since a pending entry has a p_sa field,
> I think it is elective.  Actually, an autowhite entry doesn't have
> such field.
> The following patch should reduce about 20 bytes per each pending
> entry.

manu> But OTOH, it recomputes the string representation of the IP each time
manu> we need it, instead of doingit only once. It's a speed vs memory trade. 
manu> Are we sure it does not badly impact some setups where CPU is more scarce 
manu> than memory? Anyone has an opinion on that topic? (I don't)

As far as I saw, the only place to require a string form of an IP
address is the dumping, except error message outputs.
If it raises CPU usage considerably, it is better not to apply my
patch.
milter-greylist dumps struct pending and struct autowhite.  But,
struct autowhite doesn't have a field like p_addr.  This is a reason
why I made that patch.

--
Hajimu UMEMOTO @ Internet Mutual Aid Society Yokohama, Japan
ume@...  ume@{,jp.}FreeBSD.org
http://www.imasy.org/~ume/