Yahoo Groups archive

Milter-greylist

Index last updated: 2026-04-28 23:32 UTC

Message

Re: [milter-greylist] milter-greylist 2.0.2 released

2005-10-31 by Emmanuel Dreyfus

On Sun, Oct 23, 2005 at 12:33:06AM +0900, Hajimu UMEMOTO wrote:
> I found that a pending entry has a redundant p_addr field which holds
> string form of an IP address.  Since a pending entry has a p_sa field,
> I think it is elective.  Actually, an autowhite entry doesn't have
> such field.
> The following patch should reduce about 20 bytes per each pending
> entry.

But OTOH, it recomputes the string representation of the IP each time
we need it, instead of doingit only once. It's a speed vs memory trade. 
Are we sure it does not badly impact some setups where CPU is more scarce 
than memory? Anyone has an opinion on that topic? (I don't)

-- 
Emmanuel Dreyfus
manu@...

Attachments

Move to quarantaine

This moves the raw source file on disk only. The archive index is not changed automatically, so you still need to run a manual refresh afterward.