On Fri, Jun 10, 2005 at 09:58:36AM +0200, Martin Paul wrote: > You made a mistake when integrating the domaincmp() patch - > unlike emailcmp() it returns 1 (TRUE) on a match and 0 (FALSE) > when not matching, so you have to fix this in acl.c: > > % diff acl.c.orig acl.c > 452c452 > < if (domaincmp(hostname, acl->a_domain) == 0) > --- > > if (domaincmp(hostname, acl->a_domain)) > > As it is now, "acl whitelist domain" will do the wrong thing, so > nobody should use it with 2.0rc4. Sometime a fix looks so simple you think there is no need for testing, this seems to turn always wrong... Let's roll 2.0rc5 (where I added your fix without testing it because I'm swamped with other duties, let's hope it's okay) -- Emmanuel Dreyfus manu@...
Message
Re: [milter-greylist] milter-greylist-2.0rc4 available
2005-06-10 by Emmanuel Dreyfus