Yahoo Groups archive

Milter-greylist

Index last updated: 2026-04-28 23:32 UTC

Message

Re: [milter-greylist] milter-greylist-2.0rc4 available

2005-06-10 by Martin Paul

> Here is milter-greylist 2.0 release candidate 4: 
> 
> http://ftp.espci.fr/pub/milter-greylist/milter-greylist-2.0rc4.tgz
> MD5 (milter-greylist-2.0rc4.tgz) = 1acf3770dd590b34f58e7051c5cb50cc  
> 
> The only fix is the domain suffix match, from Martin Paul.

You made a mistake when integrating the domaincmp() patch -
unlike emailcmp() it returns 1 (TRUE) on a match and 0 (FALSE)
when not matching, so you have to fix this in acl.c:

% diff acl.c.orig acl.c
452c452
<                       if (domaincmp(hostname, acl->a_domain) == 0)
---
>                       if (domaincmp(hostname, acl->a_domain))

As it is now, "acl whitelist domain" will do the wrong thing, so
nobody should use it with 2.0rc4.

The change you made to greylist.conf.5 needs a fix, too. from/rcpt
are not doing an exact, but a substring match, as mentioned in a
previous message.

% diff greylist.conf.5.orig greylist.conf.5
123c123
< When regluar expressions are not used, 
---
> When regular expressions are not used, 
127c127
< perform a case insensitive exact match with leading and trailing brackets, 
---
> perform a case insensitive substring match with leading and trailing brackets,

mp.

Attachments

Move to quarantaine

This moves the raw source file on disk only. The archive index is not changed automatically, so you still need to run a manual refresh afterward.