Milter-greylist

Emmanuel,

     Good deal.  Glad you got in.

     I verified that the crash wasn't happening, both with your 1.3.5 
build and with our 1.3.4 build in /usr/local/bin.

     Somewhat stumped, I went ahead and copied our greylist.conf and our 
greylist.db over from one of the 5 mail servers that has been crashing. 
  Sure enough, I can now crash both builds reliably, here's a log:

root@greylist:/usr/local/src/milter-greylist-1.3.5# ./milter-greylist -P 
/var/run/milter-greylist.pid -u smmsp -p 
/var/milter-greylist/milter-greylist.sock

error at line 153: parse error

root@greylist:/usr/local/src/milter-greylist-1.3.5# ps auxwww | grep milter

smmsp     3251  0.0  9.8 21848 12488 ?       S    12:56   0:00 
./milter-greylist -P /var/run/milter-greylist.pid -u smmsp -p 
/var/milter-greylist/milter-greylist.sock
smmsp     3252  0.0  9.8 21848 12488 ?       S    12:56   0:00 
./milter-greylist -P /var/run/milter-greylist.pid -u smmsp -p 
/var/milter-greylist/milter-greylist.sock
[ ...]
root      3258  0.0  0.3  1408  496 pts/3    S    12:56   0:00 grep milter

root@greylist:/usr/local/src/milter-greylist-1.3.5# ls -la /etc/mail
total 192
[ ... ]
-rw-r-----    1 root     root         6517 May 28 12:55 greylist.conf
[ ... ]
root@greylist:/usr/local/src/milter-greylist-1.3.5# touch 
/etc/mail/greylist.conf

root@greylist:/usr/local/src/milter-greylist-1.3.5# !ps
ps auxwww | grep milter

smmsp     3251  0.0  9.8 21848 12488 ?       S    12:56   0:00 
./milter-greylist -P /var/run/milter-greylist.pid -u smmsp -p 
/var/milter-greylist/milter-greylist.sock
smmsp     3252  0.0  9.8 21848 12488 ?       S    12:56   0:00 
./milter-greylist -P /var/run/milter-greylist.pid -u smmsp -p 
/var/milter-greylist/milter-greylist.sock
[ ...]
root      3262  0.0  0.3  1408  496 pts/3    S    12:57   0:00 grep milter

root@greylist:/usr/local/src/milter-greylist-1.3.5# tail -n 10 
/var/log/maillog

May 28 12:55:58 greylist sendmail[3243]: i4SJtwxw003243: Milter 
(greylist): to error state
May 28 12:55:59 greylist sendmail[3243]: i4SJtwxw003243: 
from=<kattare@...>, size=846, class=0, nrcpts=1, 
msgid=<BAY2-F8J6TE7S7CWrFy00022c13@...>, proto=ESMTP, 
daemon=MTA, relay=bay2-f8.bay2.hotmail.com [65.54.247.8]
May 28 12:55:59 greylist sendmail[3245]: i4SJtwxw003243: to=root, 
delay=00:00:01, xdelay=00:00:00, mailer=local, pri=31053, dsn=2.0.0, 
stat=Sent
May 28 12:57:22 greylist milter-greylist: reloading 
"/etc/mail/greylist.conf"
May 28 12:57:22 greylist milter-greylist: Final database dump: no change 
to dump
May 28 12:57:22 greylist milter-greylist: Exitting
May 28 12:57:22 greylist sendmail[3263]: i4SJvMxw003263: 
milter_read(greylist): cmd read returned 0, expecting 5
May 28 12:57:22 greylist sendmail[3263]: i4SJvMxw003263: Milter 
(greylist): to error state
May 28 12:57:22 greylist sendmail[3263]: i4SJvMxw003263: 
from=<kattare@...>, size=840, class=0, nrcpts=1, 
msgid=<BAY2-F63YlFkqubY3xj000082f9@...>, proto=ESMTP, 
daemon=MTA, relay=bay2-f63.bay2.hotmail.com [65.54.247.63]
May 28 12:57:22 greylist sendmail[3265]: i4SJvMxw003263: 
to=<root@...>, delay=00:00:00, xdelay=00:00:00, 
mailer=local, pri=31049, dsn=2.0.0, stat=Sent

You have new mail in /var/mail/root

root@greylist:/usr/local/src/milter-greylist-1.3.5# !ps
ps auxwww | grep milter
root      3269  0.0  0.3  1404  456 pts/3    S    12:57   0:00 grep milter

     Sometime between my touch of the greylist.conf and that final ps, 
it crashed.

     I'm 90% certain it has more to do with the greylist.db than it does 
with the greylist.conf.  I did the copy over of the greylist.conf and 
greylist.db seperately, and the crash didn't start happening until I had 
my greylist.db in place.  (I left a copy of our greylist.db in 
/etc/mail/greylist.db.kattare.)

So we have:

a) startup milter-greylist
b) touch /etc/mail/greylist.conf
c) receive new mail (triggering conf reload followed by db rebuild?)
d) crash, boom, bang.


     You'll also note that I'm getting that line 153 parse error. 
Doesn't make any sense to me.  Line 153 is near the end of the default 
file, where we've simply added a bunch of "rcpt" directives.

Cheers,

~Ethan B.



Emmanuel Dreyfus wrote:

>>    Let me know if you have any troubles or need any assistance.
> 
> 
> Yes: I can't get it to crash.
> 
> I built it from /usr/local/Src/milter-greylist-1.3.5 (it's the stock
> sources, no changes)
> 
> configured with ./configure --with-libspf_alt --with-user=smmsp
> 
> I did not install, I just ran it from its build directory. If I touch
> the config file and send a mail, it just reloads without a hitch.
> 
> Did I use a bad test? If I didn't, can you try to rebuild the binary on
> your server, just to see if the problem remains?
> 
> The build I did on your machine:
> flex-2.5.4
> bison-1.28
>

Ethan Burnside <burnside@...> wrote:

> Line 153 is near the end of the default 
> file, where we've simply added a bunch of "rcpt" directives.

Yes, it has been reported earlier today: rcpt clauses don't work anymore
without regex since 1.3.4. Another bug to fix.

Mmmm unstable branch...

-- 
Emmanuel Dreyfus
Il y a 10 sortes de personnes dans le monde: ceux qui comprennent 
le binaire et ceux qui ne le comprennent pas.
manu@...