Milter-greylist

Hi,

running and listening milter-greylist on a tcp socket, one get the
following (wrong?) message at startup:

Aug 10 11:12:54 server milter-greylist: /usr/sbin/milter-greylist: cannot
change "inet:12345@192.168.12.1" ownership to greylist/greylist: No such
file or directory

The filter itself is running fine.

Ciao
Marcus

10 \u0430\u0432\u0433\u0443\u0441\u0442\u0430 2015�\u0433. 11:17:17 CEST, "Marcus Schopen lists-yahoogroups@... [milter-greylist]" <milter-greylist@yahoogroups.com> \u043f\u0438\u0448\u0435\u0442:
>
>Hi,
>
>running and listening milter-greylist on a tcp socket, one get the
>following (wrong?) message at startup:
>
>Aug 10 11:12:54 server milter-greylist: /usr/sbin/milter-greylist:
>cannot
>change "inet:12345@192.168.12.1" ownership to greylist/greylist: No
>such
>file or directory
>
>The filter itself is running fine.
>
>Ciao
>Marcus

Which version? Stable? I think this was fixed in dev for a couple of years now... maybe even I did it, or at least nagged about it ;)
--
Typos courtesy of K-9 Mail on my Samsung Android

On Mon, 10 Aug 2015 13:03:47 +0200, "Jim Klimov jimklimov@...
[milter-greylist]" <milter-greylist@yahoogroups.com> wrote:
> 10 \u0430\u0432\u0433\u0443\u0441\u0442\u0430 2015�\u0433. 11:17:17 CEST, "Marcus Schopen
> lists-yahoogroups@... [milter-greylist]"
> <milter-greylist@yahoogroups.com> \u043f\u0438\u0448\u0435\u0442:
>>
>>Hi,
>>
>>running and listening milter-greylist on a tcp socket, one get the
>>following (wrong?) message at startup:
>>
>>Aug 10 11:12:54 server milter-greylist: /usr/sbin/milter-greylist:
>>cannot
>>change "inet:12345@192.168.12.1" ownership to greylist/greylist: No
>>such
>>file or directory
>>
>>The filter itself is running fine.
>>
>>Ciao
>>Marcus
> 
> Which version? Stable? I think this was fixed in dev for a couple of
years
> now... maybe even I did it, or at least nagged about it ;)

4.5.11-1build1 backport from Ubuntu 15.04 [1] to Ubuntu 14.04 LTS, no code
modifications, just backported it get get geoip feature.

Ciao!

[1] https://launchpad.net/ubuntu/vivid/+source/milter-greylist

Jim Klimov jimklimov@... [milter-greylist]
<milter-greylist@yahoogroups.com> wrote:

> Which version? Stable? I think this was fixed in dev for a couple of years
> now... 

It must have been something different: the current code does not check
the socket is a file before attempting a chown(2).

-- 
Emmanuel Dreyfus
http://hcpnet.free.fr/pubz
manu@...

Marcus Schopen lists-yahoogroups@... [milter-greylist]
<milter-greylist@yahoogroups.com> wrote:

> Aug 10 11:12:54 server milter-greylist: /usr/sbin/milter-greylist: cannot
> change "inet:12345@192.168.12.1" ownership to greylist/greylist: No such
> file or directory
> 
> The filter itself is running fine.

Would you want to check this fix that only sets socket ownership if it
exists in filesystem?

diff -U 4 -r1.278 milter-greylist.c
--- milter-greylist.c   4 Oct 2015 03:35:42 -0000       1.278
+++ milter-greylist.c   4 Oct 2015 03:55:25 -0000
@@ -2016,9 +2016,10 @@
 
                /* 
                 * chown the socket so that sendmail does not complain
                 */
-               if (chown(conf.c_socket, pw->pw_uid, pw->pw_gid) != 0)
+               if ((access(conf.c_socket, F_OK) == 0) &&
+                   (chown(conf.c_socket, pw->pw_uid, pw->pw_gid) != 0))
                        mg_log(LOG_WARNING, "%s: cannot change \"%s\""
                            " ownership to %s/%s: %s", argv[0], 
                            conf.c_socket, pw->pw_name, gr->gr_name,
                            strerror(errno));


-- 
Emmanuel Dreyfus
http://hcpnet.free.fr/pubz
manu@...