Milter-greylist

Here is the latest developement snapshot
http://ftp.espci.fr/pub/milter-greylist/milter-greylist-4.3.8.tgz
MD5 (milter-greylist-4.3.8.tgz) = 0e15ef8b9a89432454fbeb11137ee943

Changes since 4.3.7:
        Fix spamd hang if message contains NULL (Enrico Scholz)
        Format string for SpamAssassin score
        Build fix for Solaris
        Send the queueid to spamd (Petar Bogdanovic)
        Close-on-exec sockets to avoid file shortage with stat (Enrico Scholz)
        Add a missing comma in X-Greylist (Kouhei Sutou)
        Look for liresolv in ${libdir} instead of /usr/lib (DUFRESNE VINCENT)
        Fix SPF on Postfix (Kouhei Sutou)
-- 
Emmanuel Dreyfus
http://hcpnet.free.fr/pubz
manu@...

On Mon, 12 Jul 2010, manu@... wrote:

>        Look for liresolv in ${libdir} instead of /usr/lib (DUFRESNE VINCENT)

along the lines of auto-tools fixes, I get this with that 
4.3.8 in the auto-tools as well:

config.status: creating Makefile
config.status: WARNING:  'Makefile.in' seems to ignore the --datarootdir setting
config.status: creating milter-greylist.spec

-- Russ herrold

R P Herrold <herrold@...> wrote:

> along the lines of auto-tools fixes, I get this with that 
> 4.3.8 in the auto-tools as well:
> 
> config.status: creating Makefile
> config.status: WARNING:  'Makefile.in' seems to ignore the --datarootdir
> setting
> config.status: creating milter-greylist.spec

Hello

Will you contribute a fix?

-- 
Emmanuel Dreyfus
http://hcpnet.free.fr/pubz
manu@...

On Tue, 13 Jul 2010, manu@... wrote:

>> config.status: WARNING:  'Makefile.in' seems to ignore the --datarootdir
>> setting

> Will you contribute a fix?

sure.  per the autoconf manual, it seems to be a one liner

diff below, inline

and it now runs without that error:

[herrold@centos-5 milter-greylist]$ rpmbuild -ba \
 	milter-greylist-4.3.8.spec 2>&1 | grep datadir
+ ./configure --build=x86_64-redhat-linux-gnu 
--host=x86_64-redhat-linux-gnu 
--target=x86_64-redhat-linux-gnu --program-prefix= 
--prefix=/usr --exec-prefix=/usr --bindir=/usr/bin 
--sbindir=/usr/sbin --sysconfdir=/etc --datadir=/usr/share 
--includedir=/usr/include --libdir=/usr/lib64 
--libexecdir=/usr/libexec --localstatedir=/var 
--sharedstatedir=/usr/com --mandir=/usr/share/man 
--infodir=/usr/share/info --with-user=smmsp
[herrold@centos-5 milter-greylist]$


-- Russ herrold

4.8.3 Changed Directory Variables

In Autoconf 2.60, the set of directory variables has changed, 
and the defaults of some variables have been adjusted (see 
Installation Directory Variables) to changes in the GNU Coding 
Standards. Notably, datadir, infodir, and mandir are now 
expressed in terms of datarootdir. If you are upgrading from 
an earlier Autoconf version, you may need to adjust your files 
to ensure that the directory variables are substituted 
correctly (see Defining Directories), and that a definition of 
datarootdir is in place. For example, in a Makefile.in, adding

      datarootdir = @datarootdir@

is usually sufficient. If you use Automake to create 
Makefile.in, it will add this for you.



diff -u milter-greylist-4.3.8-ORIG/Makefile.in 
milter-greylist-4.3.8/Makefile.in
--- milter-greylist-4.3.8-ORIG/Makefile.in      2010-04-12 08:04:41.000000000 -0400
+++ milter-greylist-4.3.8/Makefile.in   2010-07-12 22:58:16.000000000 -0400
@@ -33,6 +33,7 @@
  LDFLAGS=       @LDFLAGS@
  LIBS=          @LIBS@
  prefix=                @prefix@
+datarootdir=   @datarootdir@
  exec_prefix=   @exec_prefix@
  SYSCONFDIR=    @sysconfdir@
  LOCALSTATEDIR= @localstatedir@

R P Herrold <herrold@...> wrote:

> sure.  per the autoconf manual, it seems to be a one liner

Got it. Do we need in on the 4.2 branch too?

-- 
Emmanuel Dreyfus
http://hcpnet.free.fr/pubz
manu@...

On Tue, Jul 13, 2010 at 6:18 AM,  <manu@...> wrote:
> R P Herrold <herrold@...> wrote:
>
>> sure.  per the autoconf manual, it seems to be a one liner
>
> Got it. Do we need in on the 4.2 branch too?

Please check it in so it's not forgotten but I don't think there needs
to be a 4.2.7 release only for this.

-- 
/peter

On Tue, 13 Jul 2010, manu@... wrote:

> R P Herrold <herrold@...> wrote:
>
>> sure.  per the autoconf manual, it seems to be a one liner
>
> Got it. Do we need in on the 4.2 branch too?

testing

[herrold@centos-5 milter-greylist-4.2.5]$ ./configure 2>&1 | grep data
config.status: WARNING:  'Makefile.in' seems to ignore the --datarootdir setting
[herrold@centos-5 milter-greylist-4.2.5]$

so, yes

(post patch)
[herrold@centos-5 milter-greylist-4.2.5]$ ./configure 2>&1 | grep data
[herrold@centos-5 milter-greylist-4.2.5]$

--- milter-greylist-4.2.5-ORIG/Makefile.in      2010-04-14 00:41:22.000000000 -0400
+++ milter-greylist-4.2.5/Makefile.in   2010-07-13 09:07:03.000000000 -0400
@@ -33,6 +33,7 @@
  LDFLAGS=       @LDFLAGS@
  LIBS=          @LIBS@
  prefix=                @prefix@
+datarootdir=   @datarootdir@
  exec_prefix=   @exec_prefix@
  SYSCONFDIR=    @sysconfdir@
  LOCALSTATEDIR= @localstatedir@

=========================================================================

On an unrelated matter, after solving an SMTP-AUTH issue for a 
customer last night, I would also add to the default:
 	greylist.conf
example in each branch:

#	permit without delay when receiving email from a 
#	locally authenticated sender
racl whitelist auth /.*/

-- Russ herrold

R P Herrold <herrold@...> wrote:

> On an unrelated matter, after solving an SMTP-AUTH issue for a 
> customer last night, I would also add to the default:
>       greylist.conf
> example in each branch:
> 
> #     permit without delay when receiving email from a 
> #     locally authenticated sender
> racl whitelist auth /.*/

I'm not confortable with changing defaults. It can break existing
setups, especially if the default has been there for years.

-- 
Emmanuel Dreyfus
http://hcpnet.free.fr/pubz
manu@...