Milter-greylist

Hi,

milter-greylist can't handle 'spf self' clause on Postfix
mode because Postfix doesn't support {if_addr} macro. If we
specify 'spf self' clause on Postfix mode, milter-greylist
exits with the following message:
  spf self clause is broken on Postfix

It's OK.

milter-greylist can handle other SPF clauses such as 'spf
pass' on Postfix mode. But milter-greylist also exits with
those configurations with the above message.

It seems that milter-greylist should accept those SPF
clauses on Postfix mode.

Index: ./spf.c
--- ./spf.c
+++ ./spf.c
@@ -493,11 +493,13 @@
 	acl_data_t *ad;
 	void *data;
 {
+	ad->spf_status = *(enum spf_status *)data;
 #ifdef USE_POSTFIX
-	mg_log(LOG_ERR, "spf self clause is broken on Postfix");
-	exit(EX_DATAERR);
+	if (ad->spf_status == MGSPF_SELF) {
+		mg_log(LOG_ERR, "spf self clause is broken on Postfix");
+		exit(EX_DATAERR);
+	}
 #endif
-	ad->spf_status = *(enum spf_status *)data;
 	return;
 }
 

Thanks,
-- 
kou

Kouhei Sutou <kou@...> wrote:

> It seems that milter-greylist should accept those SPF
> clauses on Postfix mode.

I checked in your patch.

-- 
Emmanuel Dreyfus
http://hcpnet.free.fr/pubz
manu@...

On Sun, May 23, 2010 at 11:06:18AM +0200, manu@... wrote:
> Kouhei Sutou <kou@...> wrote:
> 
> > It seems that milter-greylist should accept those SPF
> > clauses on Postfix mode.
> 
> I checked in your patch.

Any chances to get that into the next stable release?

		Petar Bogdanovic

Petar Bogdanovic <petar@...> wrote:

> > I checked in your patch.
> Any chances to get that into the next stable release?

Sure. I tend to backport patches when it's obvious it is not too
intrusive.

-- 
Emmanuel Dreyfus
http://hcpnet.free.fr/pubz
manu@...