Milter-greylist

Hi,

I noticed that loading dump data that includes tarpit entry
is blocked:

  main() ->
    mg_init() ->
      dump_reload() ->
        PENDING_LOCK; <- !
        dump_parse() ->
          pending_update() ->
            PENDING_LOCK; <- block!


Here is a patch to fix this problem:
  http://www.clear-code.com/~kou/patches/milter-greylist-fix-deadlock-on-parsing-dump-file-which-has-tarpit-data.patch

Thanks,
--
kou

Kouhei Sutou <kou@...> wrote:

> Here is a patch to fix this problem:

Checked in, but autowhite.c does not exists anymore, IIRC.

-- 
Emmanuel Dreyfus
http://hcpnet.free.fr/pubz
manu@...

Hi,

In <1j7es8x.11c635c1976siqM%manu@...>
  "Re: [milter-greylist] [PATCH] loading dump includes tarpit entry is blocked" on Sun, 11 Oct 2009 06:20:51 +0200,
  manu@... wrote:

> Checked in, but autowhite.c does not exists anymore, IIRC.

Yes but autowhite.c is still in the repository.
Could you remove autowhite.[ch] from the repository if they
are no longer needed?


Thanks,
--
kou

Kouhei Sutou <kou@...> wrote:

> > Checked in, but autowhite.c does not exists anymore, IIRC.
> 
> Yes but autowhite.c is still in the repository.
> Could you remove autowhite.[ch] from the repository if they
> are no longer needed?

I beleive it is not in the repository anymore: a fresh cvs checkout does
not create it.

-- 
Emmanuel Dreyfus
http://hcpnet.free.fr/pubz
manu@...

Hi,

In <1j7ie1k.stl9vi1g0yg9hM%manu@...>
  "Re: [milter-greylist] [PATCH] loading dump includes tarpit entry is blocked" on Tue, 13 Oct 2009 06:57:24 +0200,
  manu@... wrote:

>> Yes but autowhite.c is still in the repository.
>> Could you remove autowhite.[ch] from the repository if they
>> are no longer needed?
> 
> I beleive it is not in the repository anymore: a fresh cvs checkout does
> not create it.

Umm... I got autowhite.[ch]:

  % cvs -danoncvs@...:/milter-greylist co -P milter-greylist
  U milter-greylist/ChangeLog
  U milter-greylist/Makefile
  U milter-greylist/Makefile.in
  U milter-greylist/README
  U milter-greylist/acl.c
  U milter-greylist/acl.h
  U milter-greylist/autowhite.c  <- HERE
  U milter-greylist/autowhite.h  <- HERE
  U milter-greylist/clock.c
  U milter-greylist/clock.h
  U milter-greylist/conf.c
  U milter-greylist/conf.h
  U milter-greylist/conf_lex.l
  U milter-greylist/conf_yacc.y
  U milter-greylist/config.h
  U milter-greylist/config.h.in
  U milter-greylist/configure
  U milter-greylist/configure.ac
  U milter-greylist/dkimcheck.c
  U milter-greylist/dkimcheck.h
  U milter-greylist/dnsrbl.c
  U milter-greylist/dnsrbl.h
  U milter-greylist/dump.c
  U milter-greylist/dump.h
  U milter-greylist/dump_lex.l
  U milter-greylist/dump_yacc.y
  U milter-greylist/fd_pool.c
  U milter-greylist/fd_pool.h
  U milter-greylist/geoip.c
  U milter-greylist/geoip.h
  U milter-greylist/greylist.conf
  U milter-greylist/greylist.conf.5
  U milter-greylist/greylist2.conf
  U milter-greylist/install-sh
  U milter-greylist/ldapcheck.c
  U milter-greylist/ldapcheck.h
  U milter-greylist/list.c
  U milter-greylist/list.h
  U milter-greylist/macro.c
  U milter-greylist/macro.h
  U milter-greylist/milter-greylist.8
  U milter-greylist/milter-greylist.c
  U milter-greylist/milter-greylist.h
  U milter-greylist/milter-greylist.m4
  U milter-greylist/milter-greylist.spec
  U milter-greylist/milter-greylist.spec.in
  U milter-greylist/p0f.c
  U milter-greylist/p0f.h
  U milter-greylist/pending.c
  U milter-greylist/pending.h
  U milter-greylist/prop.c
  U milter-greylist/prop.h
  U milter-greylist/queue.h
  U milter-greylist/rc-bsd.sh.in
  U milter-greylist/rc-debian.sh.in
  U milter-greylist/rc-gentoo.sh.in
  U milter-greylist/rc-redhat.sh.in
  U milter-greylist/rc-solaris.sh.in
  U milter-greylist/rc-suse.sh.in
  U milter-greylist/sm_os.h
  U milter-greylist/spamd.c
  U milter-greylist/spamd.h
  U milter-greylist/spf.c
  U milter-greylist/spf.h
  U milter-greylist/stat.c
  U milter-greylist/stat.h
  U milter-greylist/store.c
  U milter-greylist/store.h
  U milter-greylist/sync.c
  U milter-greylist/sync.h
  U milter-greylist/urlcheck.c
  U milter-greylist/urlcheck.h

Thanks,
--
kou