Milter-greylist

Here is milter-greylist 4.2 beta1, a beta for our next stable release:

http://ftp.espci.fr/pub/milter-greylist/milter-greylist-4.2b1.tgz
MD5 (milter-greylist-4.2b1.tgz) = 2e76e2643469ec393a15dfce9f8ff695

Changes since the last stable release (note to contributors: if your
contribution is not properly acknowledged in the Changelog, or if you did not
made it in the AUTHORS section of the man pages, please raise your voice):

4.2b1
        Fix socket mode in sample config file
4.1.12
        Build fix for missing STAILQ_* macros
4.1.11
        Evaluate list clases in forward order (Rudy Eschauzier)
        Fix crashes on regex substring matches (Rudy Eschauzier)
4.1.10
        Build fix as some commits were missing
4.1.9
        Workaround "peer queue overflow" bugs (Laurence Moindrot, Jean Benoit)
4.1.8
        Allow regex on properties
        Allow extended regex substitution
        Custom headers can now be added to the message
        Fix build with both SpamAssassin and SPF (Joel Bertrand)
4.1.7
        Add p0f-required macros in milter-greylist.m4 (Joel Bertrand)
        Fix memory leak (Constantine A. Murenin)
        Add option to match exact domain instead of substrings (Rick Adams)
        Make sure no message chunks is skip at Data stage ACL (Manuel Badzong)
        Removes duplicate <> in SpamAssassin headers (Manuel Badzong)
        Fixes a flaw in SpamAssassin initialization (Manuel Badzong)

        Support SpamAssassin spf and dkim checks (Manuel Badzong)
        Make sure DKIM code does not use invalid pointers
        Add libspf2 support to .spec file for RPM (Joe Pruett)
        Solaris build fix (Johann Klasek)
        Fix memory leak in SpamAssassin code (Manuel Badzong)
        Make implicit default rule at DATA stage silent (Greg Troxel)
4.1.6
        Fix parse bug for "domain no" clause
        Spamassassin support (Manuel Badzong)
        Support for DATA-stage greylisting (Manuel Badzong)
        Allow syslog facility to be configured (Joe Pruett)
        Allow logging to be disabled on a per-ACL basis (Joe Pruett)
        Honour $CPPFLAGS in Makefile (Greg Troxel)
        p0f support
        Experimental DKIM support (nobody tested it)
        libspf2 support in .spec file, for RPM generation (Joe Pruett)
        status support in Debian startup script (Bernhard Schneider)
4.1.5
        Fix huge memory leaks in native LDAP support
4.1.4
        Native LDAP support through OpenLDAP
4.1.3
        Fix build of SPF code
        Fix build of GeoIP code
4.1.2
        Fix auth and tls clauses in ACL so that they accept regex
        Update Debian startup script (Adam Katz)
        Fix bogus ACL when using features not compiled in
        Fix a crash when using SPF (Johann Klasek)
        Fix Typos
4.1.1
        Fix corruption in urlcheck parsing (Benoit Branciard)
        Document what package contains libmilter
        Fix error about stat in greylist.conf (Bob Smith)
        Add configurable dumpfile permissions
        Avoid C99 specific syntax (Greg Troxel)
        Documentation fixes
        Add SPF status selection to ACL
        Add id string to ACL
        Fix typos in documentation (Constantine A. Murenin)

-- 
Emmanuel Dreyfus
http://hcpnet.free.fr/pubz
manu@...

> 
> Here is milter-greylist 4.2 beta1, a beta for our next stable release:
> 
> http://ftp.espci.fr/pub/milter-greylist/milter-greylist-4.2b1.tgz
> MD5 (milter-greylist-4.2b1.tgz) = 2e76e2643469ec393a15dfce9f8ff695
> 

Hello,

I have a compilation problem:

cc -I/usr/local/src/sendmail/libmilter/include -pthread
-D_XOPEN_SOURCE=500 -D_OSF_SOURCE -D_BSD_SOURCE -I. -I.  -c conf_yacc.c
cc: Error: conf_yacc.y, line 468: In this statement, "LOG_AUTHPRIV" is
not declared. (undeclared)
{ conf.c_logfac = LOG_AUTHPRIV; } /*NOTREACHED*/ break;
------------------^
cc: Error: conf_yacc.y, line 469: In this statement, "LOG_FTP" is not
declared. (undeclared)
{ conf.c_logfac = LOG_FTP; } /*NOTREACHED*/ break;
------------------^
*** Exit 1
Stop.
 
Actually my system does not have AUTHPRIV and FTP syslog facility in
<syslog.h>.

The fix would be easy, if the conf_yacc.c would not be a
generated file (#ifdef the small part of the code).
Since the source is in yacc I do not know what to do.
May someone help to modify the code to properly deal with this case?

Bests,
Attila

I have the same problem under Solaris 10 x86

$ make
...
cc -O -DUSE_FD_POOL -DUSE_DNSRBL -D_BSD_SOURCE -I. -I.  -c  conf_yacc.c
"conf_yacc.y", line 468: undefined symbol: LOG_AUTHPRIV
"conf_yacc.y", line 469: undefined symbol: LOG_FTP
cc: acomp failed for conf_yacc.c
*** Error code 2
make: Fatal error: Command failed for target `conf_yacc.o'



If I remove the two lines 468-469

        |       LOGFAC LOGFAC_AUTHPRIV { conf.c_logfac = LOG_AUTHPRIV; }
        |       LOGFAC LOGFAC_FTP { conf.c_logfac = LOG_FTP; }

It's OK for compilation (no test done).

Solaris Syslog.h only know the following syslog facilities.

/*
 *  Facility codes
 */
#define LOG_KERN        (0<<3)  /* kernel messages */
#define LOG_USER        (1<<3)  /* random user-level messages */
#define LOG_MAIL        (2<<3)  /* mail system */
#define LOG_DAEMON      (3<<3)  /* system daemons */
#define LOG_AUTH        (4<<3)  /* security/authorization messages */
#define LOG_SYSLOG      (5<<3)  /* messages generated internally by
syslogd */
#define LOG_LPR         (6<<3)  /* line printer subsystem */
#define LOG_NEWS        (7<<3)  /* netnews subsystem */
#define LOG_UUCP        (8<<3)  /* uucp subsystem */
#define LOG_AUDIT       (13<<3) /* audit subsystem */
#define LOG_CRON        (15<<3) /* cron/at subsystem */
        /* other codes through 15 reserved for system use */
#define LOG_LOCAL0      (16<<3) /* reserved for local use */
#define LOG_LOCAL1      (17<<3) /* reserved for local use */
#define LOG_LOCAL2      (18<<3) /* reserved for local use */
#define LOG_LOCAL3      (19<<3) /* reserved for local use */
#define LOG_LOCAL4      (20<<3) /* reserved for local use */
#define LOG_LOCAL5      (21<<3) /* reserved for local use */
#define LOG_LOCAL6      (22<<3) /* reserved for local use */
#define LOG_LOCAL7      (23<<3) /* reserved for local use */




Le mar. 10/02/2009 \ufffd 12:20, attila.bruncsak@... a \ufffdcrit :

> > 
> > Here is milter-greylist 4.2 beta1, a beta for our next stable
> release:
> > 
> > http://ftp.espci.fr/pub/milter-greylist/milter-greylist-4.2b1.tgz
> > MD5 (milter-greylist-4.2b1.tgz) = 2e76e2643469ec393a15dfce9f8ff695
> > 
> 
> Hello,
> 
> I have a compilation problem:
> 
> cc -I/usr/local/src/sendmail/libmilter/include -pthread
> -D_XOPEN_SOURCE=500 -D_OSF_SOURCE -D_BSD_SOURCE -I. -I. -c conf_yacc.c
> cc: Error: conf_yacc.y, line 468: In this statement, "LOG_AUTHPRIV" is
> not declared. (undeclared)
> { conf.c_logfac = LOG_AUTHPRIV; } /*NOTREACHED*/ break;
> ------------------^
> cc: Error: conf_yacc.y, line 469: In this statement, "LOG_FTP" is not
> declared. (undeclared)
> { conf.c_logfac = LOG_FTP; } /*NOTREACHED*/ break;
> ------------------^
> *** Exit 1
> Stop.
> 
> Actually my system does not have AUTHPRIV and FTP syslog facility in
> <syslog.h>.
> 
> The fix would be easy, if the conf_yacc.c would not be a
> generated file (#ifdef the small part of the code).
> Since the source is in yacc I do not know what to do.
> May someone help to modify the code to properly deal with this case?
> 
> Bests,
> Attila
> 
> 
> 
> 
> 
-- 
Christian P\ufffdlissier
Office National d'\ufffdtudes et de Recherches A\ufffdrospatiales
BP 72 92322 Chatillon
Tel: 33 1 46 73 44 19, Fax: 33 1 46 73 41 50

On Tue, Feb 10, 2009 at 12:20:37PM +0100, attila.bruncsak@... wrote:
> Actually my system does not have AUTHPRIV and FTP syslog facility in
> <syslog.h>.

Can you try something like this? I leave the LOGFAC_FTP as an exercise.

--- conf_yacc.y 18 Jan 2009 13:03:50 -0000      1.96
+++ conf_yacc.y 10 Feb 2009 20:00:09 -0000
@@ -464,9 +464,19 @@
        |       LOGFAC LOGFAC_LPR { conf.c_logfac = LOG_LPR; }
        |       LOGFAC LOGFAC_NEWS { conf.c_logfac = LOG_NEWS; }
        |       LOGFAC LOGFAC_UUCP { conf.c_logfac = LOG_UUCP; }
        |       LOGFAC LOGFAC_CRON { conf.c_logfac = LOG_CRON; }
-       |       LOGFAC LOGFAC_AUTHPRIV { conf.c_logfac = LOG_AUTHPRIV; }
+       |       LOGFAC LOGFAC_AUTHPRIV { 
+#ifdef LOG_AUTHPRIV
+                       conf.c_logfac = LOG_AUTHPRIV;
+#else
+                       
+                       mg_log(LOG_ERR, "Your system does not support "
+                                       "authpriv syslog facility, line %d",
+                                       conf_line);
+                       exit(EX_DATAERR);
+#endif
+       }
        |       LOGFAC LOGFAC_FTP { conf.c_logfac = LOG_FTP; }
        |       LOGFAC LOGFAC_LOCAL0 { conf.c_logfac = LOG_LOCAL0; }
        |       LOGFAC LOGFAC_LOCAL1 { conf.c_logfac = LOG_LOCAL1; }
        |       LOGFAC LOGFAC_LOCAL2 { conf.c_logfac = LOG_LOCAL2; }

-- 
Emmanuel Dreyfus
manu@...

OK. here is the diff

 diff conf_yacc.y conf_yacc.y.REF
468,488c468,469
<       |       LOGFAC LOGFAC_AUTHPRIV {
< #ifdef                LOG_AUTHPRIV
<                       conf.c_logfac = LOG_AUTHPRIV;
< #else
<                       mg_log(LOG_ERR, "Your system does not support "
<                       "authpriv syslog facility, line %d",
<                       conf_line);
<                       exit(EX_DATAERR);
< #endif
<               }
<
<       |       LOGFAC LOGFAC_FTP {
< #ifdef          LOG_FTP
<                       conf.c_logfac = LOG_FTP;
< #else
<                         mg_log(LOG_ERR, "Your system does not support
"
<                         "authpriv syslog facility, line %d",
<                         conf_line);
<                         exit(EX_DATAERR);
< #endif
<                 }
---
>       |       LOGFAC LOGFAC_AUTHPRIV { conf.c_logfac = LOG_AUTHPRIV; }
>       |       LOGFAC LOGFAC_FTP { conf.c_logfac = LOG_FTP; }



Le mar. 10/02/2009 \ufffd 13:40, Emmanuel Dreyfus a \ufffdcrit :
> On Tue, Feb 10, 2009 at 12:20:37PM +0100, attila.bruncsak@...
> wrote:
> > Actually my system does not have AUTHPRIV and FTP syslog facility in
> > <syslog.h>.
> 
> Can you try something like this? I leave the LOGFAC_FTP as an
> exercise.
> 
> --- conf_yacc.y 18 Jan 2009 13:03:50 -0000 1.96
> +++ conf_yacc.y 10 Feb 2009 20:00:09 -0000
> @@ -464,9 +464,19 @@
> | LOGFAC LOGFAC_LPR { conf.c_logfac = LOG_LPR; }
> | LOGFAC LOGFAC_NEWS { conf.c_logfac = LOG_NEWS; }
> | LOGFAC LOGFAC_UUCP { conf.c_logfac = LOG_UUCP; }
> | LOGFAC LOGFAC_CRON { conf.c_logfac = LOG_CRON; }
> - | LOGFAC LOGFAC_AUTHPRIV { conf.c_logfac = LOG_AUTHPRIV; }
> + | LOGFAC LOGFAC_AUTHPRIV { 
> +#ifdef LOG_AUTHPRIV
> + conf.c_logfac = LOG_AUTHPRIV;
> +#else
> + 
> + mg_log(LOG_ERR, "Your system does not support "
> + "authpriv syslog facility, line %d",
> + conf_line);
> + exit(EX_DATAERR);
> +#endif
> + }
> | LOGFAC LOGFAC_FTP { conf.c_logfac = LOG_FTP; }
> | LOGFAC LOGFAC_LOCAL0 { conf.c_logfac = LOG_LOCAL0; }
> | LOGFAC LOGFAC_LOCAL1 { conf.c_logfac = LOG_LOCAL1; }
> | LOGFAC LOGFAC_LOCAL2 { conf.c_logfac = LOG_LOCAL2; }
> 
> -- 
> Emmanuel Dreyfus
> manu@...
> 
> 
> 
> 
-- 
Christian P\ufffdlissier
Office National d'\ufffdtudes et de Recherches A\ufffdrospatiales
BP 72 92322 Chatillon
Tel: 33 1 46 73 44 19, Fax: 33 1 46 73 41 50

> OK. here is the diff

It compiles now fine on Tru64 UNIX, thanks.
Small thing only, the second case the error instead of:
mg_log(LOG_ERR, "Your system does not support authpriv syslog facility,
line %d",
should be:
mg_log(LOG_ERR, "Your system does not support ftp syslog facility, line
%d",