Milter-greylist

Hi,

I just downloaded the latest milter-greylist 4.0rc1.

It has a problem with the spec file contained in the package, which I've
discussed here with Dries (when I originally asked if he could make it
available in rpmforge):

http://www.mail-archive.com/suggest@.../msg00048.html

and to which he committed a fix here:

http://lists.rpmforge.net/pipermail/svn-commits/2007-September/004904.html

But after creating the 4.0rc1 RPM, I notice the problem is still there:

drwxr-xr-x   2 root    root     4096 Oct 23 14:07 milter-greylist

which has to be set to:

drwxr-xr-x   2 smmsp   smmsp    4096 Oct 23 14:07 milter-greylist

otherwise milter-greylist bombs out with the error:

Oct 23 13:35:47 server milter-greylist: greylist: Unable to bind to port
/var/milter-greylist/milter-greylist.
sock: Permission denied
Oct 23 13:35:47 server milter-greylist: greylist: Unable to create listening
socket on conn /var/milter-greyli
st/milter-greylist.sock

Could you please fix the spec file in the package.

Also, just for your interest, I went from the 3.0 stable to 4.01rc1, and also
got the following error:

Oct 23 13:35:46 server milter-greylist: unknown token "[" line 105771, skipping
Oct 23 13:35:46 server milter-greylist: dump error at line 105771: syntax error
Oct 23 13:35:46 server milter-greylist: unknown token "]" line 105771, skipping
Oct 23 13:35:46 server milter-greylist: unknown token ">" line 105771, skipping
Oct 23 13:35:46 server milter-greylist: unknown token "[" line 105772, skipping
Oct 23 13:35:46 server milter-greylist: dump error at line 105772: syntax error
Oct 23 13:35:46 server milter-greylist: unknown token "]" line 105772, skipping
Oct 23 13:35:46 server milter-greylist: unknown token ">" line 105772, skipping

which had to do with these entries in /var/milter-greylist/greylist.db:

xx.xx.xx.xxx    <>      <postmaster@[IP_of_OneOfMy_MX_servers]>    1196078149
AUTO # 2007-11-26 22:55:49
xx.xx.xx.xxx    <>      <postmaster@[IP_of_AnotherOfMy_MX_servers]>   
1196078149 AUTO # 2007-11-26 22:55:49

I deleted the two entries and restarted milter-greylist, all was fine then.

Regards,

Michael.

On Tue, Oct 23, 2007 at 02:39:05PM +1000, Michael Mansour wrote:
> But after creating the 4.0rc1 RPM, I notice the problem is still there:

No surprise since nobody reported it.
And the patch does not apply to the specfile included with milter-greylist,
which might be why the fix was not reported: perhaps it just does not belong
here.

> Could you please fix the spec file in the package.

Send a patch...

> Also, just for your interest, I went from the 3.0 stable to 4.01rc1, and also
> got the following error:
> 
> Oct 23 13:35:46 server milter-greylist: unknown token "[" line 105771, skipping

That should be harmless, milter-greylist should still be able to startup. 
If it's not the case then that a bug that needs to be fixed.

-- 
Emmanuel Dreyfus
manu@...

Hi Emmanuel,

> On Tue, Oct 23, 2007 at 02:39:05PM +1000, Michael Mansour wrote:
> > But after creating the 4.0rc1 RPM, I notice the problem is still there:
> 
> No surprise since nobody reported it.
> And the patch does not apply to the specfile included with milter-
> greylist, which might be why the fix was not reported: perhaps it 
> just does not belong here.

Yeah, I didn't mean for your to actually use the patch supplied there, as
rpmforge use their own spec files produced by Dag's dar software from memory.
But all I wanted for you to note was the one line change required in your spec
ie. the "chown smmsp:smmsp" line.

> > Could you please fix the spec file in the package.
> 
> Send a patch...

Ok, this is just a one line change. If you still want me to supply a patch
I'll do it and forward one onto you. But you only need to add the "chown
smmsp:smmsp" line as shown in the:

http://lists.rpmforge.net/pipermail/svn-commits/2007-September/004904.html

link (which seems to be down atm).

> > Also, just for your interest, I went from the 3.0 stable to 4.01rc1, and also
> > got the following error:
> > 
> > Oct 23 13:35:46 server milter-greylist: unknown token "[" line 105771,
skipping
> 
> That should be harmless, milter-greylist should still be able to 
> startup. If it's not the case then that a bug that needs to be fixed.

Yeah, milter-greylist was still able to start, I just thought I should report
the problem.

Thanks.

Michael.

> -- 
> Emmanuel Dreyfus
> manu@...
------- End of Original Message -------

On Tue, 23 Oct 2007 14:39:05 +1000 Michael Mansour <mic@...> wrote:

> But after creating the 4.0rc1 RPM, I notice the problem is still there:
> drwxr-xr-x   2 root    root     4096 Oct 23 14:07 milter-greylist
> which has to be set to:
> drwxr-xr-x   2 smmsp   smmsp    4096 Oct 23 14:07 milter-greylist

I created rpm with a command: rpmbuild --define "build_user smmsp" -tb milter-greylist-4.0xx.tgz
and it created rpm with:
drwxr-xr-x    2 smmsp   root                0 Spa 11 22:53 /var/milter-greylist

> I deleted the two entries and restarted milter-greylist, all was fine then.

It works w/o deleting entries - they will be cleaned up when milter-greylist
writes db file next time.

Regards,
Nerijus

Nerijus Baliunas <nerijus@...> wrote:

> I created rpm with a command: 
> rpmbuild --define "build_user smmsp" -tb milter-greylist-4.0xx.tgz
> and it created rpm with:
> drwxr-xr-x    2 smmsp   root      0 Spa 11 22:53 /var/milter-greylist

No need to change anything, then?

-- 
Emmanuel Dreyfus
http://hcpnet.free.fr/pubz
manu@...

Hi Emmanuel,

> Nerijus Baliunas <nerijus@...> wrote:
> 
> > I created rpm with a command: 
> > rpmbuild --define "build_user smmsp" -tb milter-greylist-4.0xx.tgz
> > and it created rpm with:
> > drwxr-xr-x    2 smmsp   root      0 Spa 11 22:53 /var/milter-greylist
> 
> No need to change anything, then?

No, the spec file does need to be fixed. 

Building an RPM manually is usually done with the least amount of arguments
like this:

# rpmbuild -bb milter-greylist.spec

The additional variables defined by the "--define" parameter is a workaround
for the error with the spec. If the spec was fixed, the workaround would not
be needed.

Regards,

Michael.

> -- 
> Emmanuel Dreyfus
> http://hcpnet.free.fr/pubz
> manu@...
------- End of Original Message -------

> Hi Emmanuel,
> 
> > Nerijus Baliunas <nerijus@...> wrote:
> > 
> > > I created rpm with a command: 
> > > rpmbuild --define "build_user smmsp" -tb milter-greylist-4.0xx.tgz
> > > and it created rpm with:
> > > drwxr-xr-x    2 smmsp   root      0 Spa 11 22:53 /var/milter-greylist
> > 
> > No need to change anything, then?
> 
> No, the spec file does need to be fixed.
> 
> Building an RPM manually is usually done with the least amount of arguments
> like this:
> 
> # rpmbuild -bb milter-greylist.spec
> 
> The additional variables defined by the "--define" parameter is a workaround
> for the error with the spec. If the spec was fixed, the workaround 
> would not be needed.

You should also note Emmanuel that the command he used earlier does not even
use the spec file.

Regards,

Michael.

> > -- 
> > Emmanuel Dreyfus
> > http://hcpnet.free.fr/pubz
> > manu@...
> ------- End of Original Message -------
------- End of Original Message -------

On Tue, Oct 23, 2007 at 09:49:48PM +1000, Michael Mansour wrote:
> Ok, this is just a one line change. If you still want me to supply a patch
> I'll do it and forward one onto you.

As I don't use that RPM stuff, I'm no enthousiast at touching it on my own:
I don't even know how to test a change is fine. So send a patch, and 
don't miss that milter-greylist.spec is generated by configure...

-- 
Emmanuel Dreyfus
manu@...

On Wed, 24 Oct 2007 15:22:53 +1000 Michael Mansour <mic@...> wrote:

> You should also note Emmanuel that the command he used earlier does not even
> use the spec file.

If you mean rpmbuild --define "build_user smmsp" -tb milter-greylist-4.0xx.tgz
does not use the spec file you are incorrect.

Regards,
Nerijus

On Wed, 24 Oct 2007 15:17:24 +1000 Michael Mansour <mic@...> wrote:

> No, the spec file does need to be fixed. 
> 
> Building an RPM manually is usually done with the least amount of arguments
> like this:
> 
> # rpmbuild -bb milter-greylist.spec
> 
> The additional variables defined by the "--define" parameter is a workaround
> for the error with the spec.

No, they are features. But you are right that default build without --defines
should work without changing permissions manually. So it you think that
user smmsp should be default for rpm, please change the spec file (without
breaking a possibility to define another user) and provide a patch.

Regards,
Nerijus