Milter-greylist

Here is it:

http://ftp.espci.fr/pub/milter-greylist/milter-greylist-3.0rc5.tgz
MD5 (milter-greylist-3.0rc5.tgz) = 82326be5d21ca8ef7bb4e3cdbcbd23c6

Changes since rc4:
        Pointer to DRAC documentation (Matthias Scheler)
        FreeBSD build fixes (Hajimu UMEMOTO)
        Remove the /tmp/access-list.debug for security sake (AIDA Shinra)
        Correctly enable non blocking I/O fox MX sync (Attila Bruncsak)

Attila: I have not included your proposed fix to the final dump problem. I
think it's too intrusive to be checked in at this stage of the release
cycle. We'll try to fix it in the 3.1.x branch.

-- 
Emmanuel Dreyfus
http://hcpnet.free.fr/pubz
manu@...

On Sat, Oct 14, 2006 at 11:43:01AM +0200, Emmanuel Dreyfus wrote:
> Here is it:
> 
> http://ftp.espci.fr/pub/milter-greylist/milter-greylist-3.0rc5.tgz
> MD5 (milter-greylist-3.0rc5.tgz) = 82326be5d21ca8ef7bb4e3cdbcbd23c6
> 
> Changes since rc4:
>         Pointer to DRAC documentation (Matthias Scheler)
>         FreeBSD build fixes (Hajimu UMEMOTO)
>         Remove the /tmp/access-list.debug for security sake (AIDA Shinra)
>         Correctly enable non blocking I/O fox MX sync (Attila Bruncsak)

The configuration file issue got worse. The program still uses the old
hard coded path "/etc/mail/greylist.conf" put the "Makefile" now
installs the configuration to "${sysconfdir}/mail".

	Kind regards

-- 
Matthias Scheler                                  http://zhadum.org.uk/

Matthias Scheler <tron@...> wrote:

> The configuration file issue got worse. The program still uses the old
> hard coded path "/etc/mail/greylist.conf" put the "Makefile" now
> installs the configuration to "${sysconfdir}/mail".

I committed that change by mistake. I'll back it out, except if I find
the way to specify a default for sysconfdir and localstatedir.

-- 
Emmanuel Dreyfus
http://hcpnet.free.fr/pubz
manu@...

manu@... wrote:
> Here is it:
> 
> http://ftp.espci.fr/pub/milter-greylist/milter-greylist-3.0rc5.tgz
> MD5 (milter-greylist-3.0rc5.tgz) = 82326be5d21ca8ef7bb4e3cdbcbd23c6
> 
> Changes since rc4:
>         Pointer to DRAC documentation (Matthias Scheler)
>         FreeBSD build fixes (Hajimu UMEMOTO)
>         Remove the /tmp/access-list.debug for security sake (AIDA Shinra)
>         Correctly enable non blocking I/O fox MX sync (Attila Bruncsak)
> 
> Attila: I have not included your proposed fix to the final dump problem. I
> think it's too intrusive to be checked in at this stage of the release
> cycle. We'll try to fix it in the 3.1.x branch.
> 

For what it's worth, I can't build 3.0rc5 without a little hand-hacking.

Here's my  configure:
./configure --enable-dnsrbl  --with-libbind=/usr/lib/
<snip>
checking for vsyslog... no
<snip>

However, I do have vsyslog, so the make fails:

[milter-greylist-3.0rc5]$ make
gcc -g -O2 -Wall -I/usr/lib//include/bind -I/usr/lib//include -D_XOPEN_SOURCE=500 -D
USE_DNSRBL -D_BSD_SOURCE   -c -o milter-greylist.o milter-greylist.c
milter-greylist.c: In function `vsyslog':
milter-greylist.c:1437: argument `fmt' doesn't match prototype
/usr/include/sys/syslog.h:188: prototype declaration


If I hack config.h to define HAVE_VSYSLOG it works great.

Matt Kettler <mkettler@...> wrote:

> Here's my  configure:
> ./configure --enable-dnsrbl  --with-libbind=/usr/lib/
> <snip>
> checking for vsyslog... no
> <snip>
> 
> However, I do have vsyslog, so the make fails:
> 
> [milter-greylist-3.0rc5]$ make
> gcc -g -O2 -Wall -I/usr/lib//include/bind -I/usr/lib//include
> -D_XOPEN_SOURCE=500 -D USE_DNSRBL -D_BSD_SOURCE   -c -o milter-greylist.o
> milter-greylist.c
> milter-greylist.c: In function `vsyslog':
> milter-greylist.c:1437: argument `fmt' doesn't match prototype
> /usr/include/sys/syslog.h:188: prototype declaration
> 
> 
> If I hack config.h to define HAVE_VSYSLOG it works great.

What is your OS?
Do you have vsyslog in <sys/syslog.h> or not?
Can you show the relevant part of config.log, where vsyslog is checked?

-- 
Emmanuel Dreyfus
http://hcpnet.free.fr/pubz
manu@...

manu@... wrote:
> Matt Kettler <mkettler@...> wrote:
> 
>> Here's my  configure:
>> ./configure --enable-dnsrbl  --with-libbind=/usr/lib/
>> <snip>
>> checking for vsyslog... no
>> <snip>
>>
>> However, I do have vsyslog, so the make fails:
>>
>> [milter-greylist-3.0rc5]$ make
>> gcc -g -O2 -Wall -I/usr/lib//include/bind -I/usr/lib//include
>> -D_XOPEN_SOURCE=500 -D USE_DNSRBL -D_BSD_SOURCE   -c -o milter-greylist.o
>> milter-greylist.c
>> milter-greylist.c: In function `vsyslog':
>> milter-greylist.c:1437: argument `fmt' doesn't match prototype
>> /usr/include/sys/syslog.h:188: prototype declaration
>>
>>
>> If I hack config.h to define HAVE_VSYSLOG it works great.
> 
> What is your OS?

It's a patched Redhat 9 box. (Most notable: I had to build my own libbind
because libresolv doesn't export some of the functions you're using, and none of
the OS native packages includes libbind.)

> Do you have vsyslog in <sys/syslog.h> or not?

Given the last line of the error message, yes.

/usr/include/sys/syslog.h:188: prototype declaration


> Can you show the relevant part of config.log, where vsyslog is checked?
> 

Ahh, now I see the cause.. libbind is breaking it because it requires pthread:

configure:5329: result: no
configure:5241: checking for vsyslog
configure:5298: gcc -o conftest -g -O2 -Wall -I/usr/lib//include/bind
-I/usr/lib//include   -L/usr/lib//lib -Wl,--rpath=/usr/lib//lib conftest.c
-lbind  >&5
/usr/lib/gcc-lib/i386-redhat-linux/3.2.2/../../../libbind.so: undefined
reference to `pthread_getspecific'
/usr/lib/gcc-lib/i386-redhat-linux/3.2.2/../../../libbind.so: undefined
reference to  `pthread_key_create'
/usr/lib/gcc-lib/i386-redhat-linux/3.2.2/../../../libbind.so: undefined
reference to  `pthread_setspecific'
collect2: ld returned 1 exit status


You might want to try to find a way to drop -lbind from the configure tests, or
add -lpthread.

According to Matt Kettler:
> > 
> > http://ftp.espci.fr/pub/milter-greylist/milter-greylist-3.0rc5.tgz
> > MD5 (milter-greylist-3.0rc5.tgz) = 82326be5d21ca8ef7bb4e3cdbcbd23c6
> 
> For what it's worth, I can't build 3.0rc5 without a little hand-hacking.

I can't either using Linux and --enable-dnsrbl 

gcc -g -O2 -Wall -D_XOPEN_SOURCE=500 -DUSE_DNSRBL -D_BSD_SOURCE   -c -o dnsrbl.o dnsrbl.c
dnsrbl.c: In function 'dnsrbl_check_source':
dnsrbl.c:163: warning: pointer targets in passing argument 5 of '__res_nquery' differ in signedness
dnsrbl.c:167: warning: pointer targets in passing argument 1 of '__ns_initparse' differ in signedness

...

gcc -o milter-greylist milter-greylist.o pending.o sync.o dnsrbl.o list.o macro.o conf_yacc.o dump_yacc.o conf.o autowhite.o dump.o spf.o acl.o  -lresolv -lnsl -lpthread -lmilter
dnsrbl.o: In function `dnsrbl_check_source':/src/milter-greylist-3.0rc5/dnsrbl.c:167: undefined reference to `__ns_initparse'
:/src/milter-greylist-3.0rc5/dnsrbl.c:174: undefined reference to `__ns_parserr'
collect2: ld returned 1 exit status
make: *** [milter-greylist] Error 1


It's okay if I don't specify --enable-dnsrbl.
With --enable-dnsrbl, it must be linked with /usr/lib/libresolv.a
instead of -lresolv. Maybe -lbind could do it (I don't have it on that box).

BTW, my patch for configure.ac in 2.1.* has been changed at some point from:

       [if test x$enableval = xyes; then
               if test $rdns = yes; then
                       CFLAGS=$CFLAGS" -DUSE_DNSRBL"
               else
                       echo "--enable-dnsrbl used but DNS resolver is not thread safe";
                       echo "Try installing BIND9 and using --with-libbind, or if you";
                       echo "know what you are doing, use --with-thread-safe-resolver";
                       exit 1;
               fi
        fi


to

       [if test x$enableval = xyes -a $rdns = yes; then
               CFLAGS=$CFLAGS" -DUSE_DNSRBL"
        else
               echo "--enable-dnsrbl used but DNS resolver is not thread safe";
               echo "Try installing BIND9 and using --with-libbind, or if you";
               echo "know what you are doing, use --with-thread-safe-resolver";
               exit 1;
        fi

..but this is not equivalent and it's even wrong as --disable-dnsrbl will
produce the echo. Please revert that change.

/Fabien

Fabien Tassin wrote:
> According to Matt Kettler:
>>> http://ftp.espci.fr/pub/milter-greylist/milter-greylist-3.0rc5.tgz
>>> MD5 (milter-greylist-3.0rc5.tgz) = 82326be5d21ca8ef7bb4e3cdbcbd23c6
>> For what it's worth, I can't build 3.0rc5 without a little hand-hacking.
> 
> I can't either using Linux and --enable-dnsrbl 
> 
> gcc -g -O2 -Wall -D_XOPEN_SOURCE=500 -DUSE_DNSRBL -D_BSD_SOURCE   -c -o dnsrbl.o dnsrbl.c
> dnsrbl.c: In function 'dnsrbl_check_source':
> dnsrbl.c:163: warning: pointer targets in passing argument 5 of '__res_nquery' differ in signedness
> dnsrbl.c:167: warning: pointer targets in passing argument 1 of '__ns_initparse' differ in signedness
> 
> ...
> 
> gcc -o milter-greylist milter-greylist.o pending.o sync.o dnsrbl.o list.o macro.o conf_yacc.o dump_yacc.o conf.o autowhite.o dump.o spf.o acl.o  -lresolv -lnsl -lpthread -lmilter
> dnsrbl.o: In function `dnsrbl_check_source':/src/milter-greylist-3.0rc5/dnsrbl.c:167: undefined reference to `__ns_initparse'
> :/src/milter-greylist-3.0rc5/dnsrbl.c:174: undefined reference to `__ns_parserr'
> collect2: ld returned 1 exit status
> make: *** [milter-greylist] Error 1
> 
> 
> It's okay if I don't specify --enable-dnsrbl.
> With --enable-dnsrbl, it must be linked with /usr/lib/libresolv.a
> instead of -lresolv. Maybe -lbind could do it (I don't have it on that box).

I found that using libbind did solve this exact problem.

There's actually quite a few platforms out there that do not export ns_initparse
from libresolv.

http://www.google.com/search?hl=en&q=undefined+reference+to+%60__ns_initparse%27&btnG=Google+Search

It's also undocumented in the libc documentation (of which libresolv is a part),
but is documented in several books:

http://lists.debian.org/debian-glibc/2005/01/msg00111.html

Matt Kettler <mkettler@...> wrote:

> configure:5329: result: no
> configure:5241: checking for vsyslog
> configure:5298: gcc -o conftest -g -O2 -Wall -I/usr/lib//include/bind
> -I/usr/lib//include   -L/usr/lib//lib -Wl,--rpath=/usr/lib//lib conftest.c
> -lbind  >&5
> /usr/lib/gcc-lib/i386-redhat-linux/3.2.2/../../../libbind.so: undefined
> reference to `pthread_getspecific'

So that fails at yours?
test.c:
int main(void) { return 0; }

cc -o test -lbind test.c


And that works?
cc -o test -lpthread -lbind test.c

Of course, the easy fix is to use --with-libpthread, but I have to agree
the vsyslog error is meaningless.

-- 
Emmanuel Dreyfus
http://hcpnet.free.fr/pubz
manu@...

manu@... wrote:
> Matt Kettler <mkettler@...> wrote:
> 
>> configure:5329: result: no
>> configure:5241: checking for vsyslog
>> configure:5298: gcc -o conftest -g -O2 -Wall -I/usr/lib//include/bind
>> -I/usr/lib//include   -L/usr/lib//lib -Wl,--rpath=/usr/lib//lib conftest.c
>> -lbind  >&5
>> /usr/lib/gcc-lib/i386-redhat-linux/3.2.2/../../../libbind.so: undefined
>> reference to `pthread_getspecific'
> 
> So that fails at yours?
> test.c:
> int main(void) { return 0; }
> 
> cc -o test -lbind test.c

Yep.

$ cc -o test -lbind test.c
/usr/lib/gcc-lib/i386-redhat-linux/3.2.2/../../../libbind.so: undefined
reference to `pthread_getspecific'
/usr/lib/gcc-lib/i386-redhat-linux/3.2.2/../../../libbind.so: undefined
reference to `pthread_key_create'
/usr/lib/gcc-lib/i386-redhat-linux/3.2.2/../../../libbind.so: undefined
reference to `pthread_setspecific'
collect2: ld returned 1 exit status
$

> 
> 
> And that works?
> cc -o test -lpthread -lbind test.c

Yep:
$ cc -o test -lpthread -lbind test.c
$

> Of course, the easy fix is to use --with-libpthread, but I have to agree
> the vsyslog error is meaningless.

Strangely, that alone does not fix it. Configure still calls the vsyslog test
with -lbind, but no -lpthread.

From config.log:


It was created by milter-greylist configure 3.0rc3, which was
generated by GNU Autoconf 2.59.  Invocation command line was

  $ ./configure --enable-dnsrbl --with-libbind=/usr/lib/ --with-libpthread

<snip>

configure:5298: gcc -o conftest -g -O2 -Wall -Iyes/include
-I/usr/lib//include/bind -I/usr/lib//include   -Lyes/lib -Wl,--rpath=yes/lib
 -L/usr/lib//lib -Wl,--rpath=/usr/lib//lib conftest.c -lbind  >&5
/usr/lib/gcc-lib/i386-redhat-linux/3.2.2/../../../libbind.so: undefined
reference to `pthread_getspecific'
/usr/lib/gcc-lib/i386-redhat-linux/3.2.2/../../../libbind.so: undefined
reference to `pthread_key_create'
/usr/lib/gcc-lib/i386-redhat-linux/3.2.2/../../../libbind.so: undefined
reference to `pthread_setspecific'
collect2: ld returned 1 exit status