Yahoo Groups archive

Milter-greylist

Index last updated: 2026-04-28 23:32 UTC

Message

Re: [milter-greylist] MX synchronisation bug?

2004-12-06 by Remy Card

On Mon, Dec 06, 2004 at 07:27:55AM +0100, Remy Card wrote:
> > Sounds good. Someone test that fix?
> 
> 	Note that this could be a bit more complex than what I wrote.  After
> re-reading the code and thinking of it again, I believe that a fictive
> pending record should be allocated and initialized to be used as a
> parameter to peer_delete().  The fictive record should not be added to
> the pending list.

	Ok, I wrote the fix.  I cannot send the patch since I added the fix
in my ACL development version, but it is quite easy to add in autowhite.c:

- add:
#include "sync.h"
- in autowhite_check, add a local variable:
        struct pending *pending;
- in autowhite_check, add:
                        /*
                         * We need to tell our peers about this, we use a
                         * fictive pending record
                         */
                        pending = pending_get(sa, salen, from, rcpt,
                            (time_t)0);
                        if (pending != NULL) {
                                peer_delete(pending);
                                pending_put(pending);
                        }
  after:
                        syslog(LOG_INFO, "%s: addr %s from %s rcpt %s: "
                                "autowhitelisted for more %02d:%02d:%02d",
                                queueid, addr, from, rcpt, h, mn, s);

	I plan to release an ACL patch RSN.  The two MX sync fixes will be
included in this patch.

		R\ufffdmy

Attachments

Move to quarantaine

This moves the raw source file on disk only. The archive index is not changed automatically, so you still need to run a manual refresh afterward.