Milter-greylist

On Mon, Dec 06, 2004 at 02:22:21AM +0100, manu@... wrote:
> Remy Card <Remy.Card@...> wrote:
> >       I suggest to add a test at the beginning of sync_queue():
> > 
> >       if (peer->p_flags & P_LOCAL)
> >               return;
> > 
> >       This will prevent milter-greylist from queuing records to a local
> > peer.  And, BTW, this will fix a memory leak in milter-greylist (pending
> > records that are added to the local peer list are never deallocated since
> > their reference count will never be decremented).
> 
> The memory leak is limited because once the queue is full, it stops
> growing.

	Right.  But, then, your log files grow as overflow error messages are
generated when pending records are added to the peer sync list.

> Your analysis and your fix seem good to me. Did you tested it? Can I
> commit it now? Should 1.6 include that fix? That will bound us to
> another release candidate. Given that the problem is minor (a limited
> chunk of ram held for nothing), I'd be in favor of only applying to the
> developement branch and release 1.6 as is.

	I have tested this fix.  After applying it, overflow messages have
disappeared from my log files.  Anyway, since this is a minor bug, I vote
for applying the fix to the development branch if you don't want to release
another 1.6rc version.

		R\ufffdmy