Milter-greylist

On 27 September 2015 17:37:07 BST, "manu@... [milter-greylist]"  wrote:
Steven Hiscocks steven@... [milter-greylist]
 wrote:

 Sorry. Previous patch had significant bug due to me misinterpreting
the
 case statement in spf.c, setting the result string to test value as
set
 in configuration.  New patch attached.

Sorry
for not replying earlier, I had trouble with a dying computer at
home. A few comments:
No worries.


- you introduced priv->priv_sr.sr_addheader_ins  and
ap.ap_addheader_ins
the _ins suffix is not very self-explaining. What about _index ?
Changed to index in attached patch.


- Why EXF_DKIM changed value?
If I remember  correctly, I added the DKIM reason message, but it kept triggering when 'nolog' was set. Maybe I misinterpreted it, but it just seemed strange for two constants to have the value.


- in conf_yacc.y,
milter-greylist.c, spf.c, please stick to 80
char/lines maximum. (tab is 8 spaces)
Hopefully sorted now in attached patch.


Otherwise, this seems nice.
Thanks.

Also changed SPF "hardfail" to "fail" to comply with SPF header standards.

--
Steven Hiscocks