Milter-greylist

Steven Hiscocks steven@... [milter-greylist]
<milter-greylist@yahoogroups.com> wrote:

> Sorry. Previous patch had significant bug due to me misinterpreting the
> case statement in spf.c, setting the result string to test value as set
> in configuration.  New patch attached.

Sorry for not replying earlier, I had trouble with a dying computer at
home. A few comments:

- you introduced priv->priv_sr.sr_addheader_ins  and ap.ap_addheader_ins
the _ins suffix is not very self-explaining. What about _index ?

- Why EXF_DKIM changed value?

- in conf_yacc.y, milter-greylist.c, spf.c, please stick to 80
char/lines maximum. (tab is 8 spaces)

Otherwise, this seems nice.
-- 
Emmanuel Dreyfus
http://hcpnet.free.fr/pubz
manu@...