Milter-greylist

New revision attached, without printf and with two strstr substring
matches (A in B or B in A).

Merry H-Mas,
Jim Klimov


2014-12-23 17:02, Jim Klimov jimklimov@... [milter-greylist] \u043f\u0438\u0448\u0435\u0442:
> 2014-12-23 16:27, Emmanuel Dreyfus manu@... [milter-greylist] \u043f\u0438\u0448\u0435\u0442:
>  > On Tue, Dec 23, 2014 at 02:30:02PM +0300, Jim Klimov jimklimov@...
>  > [milter-greylist] wrote:
>  > > Patch attached to call format string expansion (any defined format)
>  > > in the helo_strstr clause. And case-insensitivity while we are at it.
>  >
>  > Thanks, but could you remove the debug printf?
>
> Yes, no problem. It was there when I barged in, so I left it there.
> I had no idea who would use it - I didn't see this in the outputs -
> so chose to leave it as it was.
>
> By the way, am I correct that there is currently no configurable
> level of debugging verbosity - just an on/off toggle?
>
> Finally, regarding substring matches: I saw this today:
>
> Dec 23 16:39:12 relay-mta milter-greylist: [ID 421884 mail.debug]
> acl_helo_strstr -> 'ximea.com'/'mail.ximea.com' (lowercase of
> 'ximea.com'/'mail.ximea.com') - MISMATCH
>
> Indeed, the longer test string is not part of the shorter one.
>
> Would it break any assumptions possibly used in the field today,
> if we extend the test to try it both ways, roughly speaking:
> strstr(helo,dns)||strstr(dns,helo)
> this?
>
> Thanks,
> Jim Klimov
>