Milter-greylist

Jim Klimov <jimklimov@...> wrote:

> # This is in wrong order by a couple of lines - you should first
> set the priv->priv_hostname value with strncpy(), then fix it :)

Right.

> # Also, this is geared towards exactly resolving a bracketed name.
> My code could also do resolution in the (theoretical) case that a
> numeric IP address was passed without brackets. Then again, this
> routine is called "unbracketing" for a reason ;)

I prefer to address real problems rather than potential ones.
 
> # In the routine itself you have an ifdef... I think it warrants
> an #else to report that unbracketing was needed and requested, but
> the program was configured and built without proper DNS support.

Updated version: http://ftp.espci.fr/shadow/manu/unbracket2.patch

-- 
Emmanuel Dreyfus
http://hcpnet.free.fr/pubz
manu@...