Milter-greylist

On 2013-08-13 12:07, Jim Klimov wrote:
> The main question is: if the "local address" is wrong in p0f.c:380,
> should we really abort the whole program, or just not do further p0f
> processing?
>
> Also, I did not find a (documented) toggle to disable p0f if it was
> enabled during compilation. There are currently no configuration lines
> with "p0f" in my config, but the codepath is taken and in certain cases
> leads to program abortion...


So here's a patch which I hope would help me :)

This includes two fixes:
1) Do not abort the program on bad address family, but just exit the
routine - same as we do later for bad sockets, etc.

2) Report inability to connect to a socket, once in a row. Reset the
flag which blocks these reports upon a successful connection (i.e.
for cases that p0fd was restarting and was temporarily unavailable).
In my case with p0f commented away from greylist.conf, this prints

Aug 13 15:08:50 ucs milter-greylist: [ID 291231 mail.error] can't 
connect to p0f socket "", skipping p0f

and thus prompts the admin (me) to fix the config and add a socket
name, but does not do so upon every message, either :)

HTH,
//Jim Klimov