Yahoo Groups archive

Milter-greylist

Index last updated: 2026-04-28 23:32 UTC

Message

Re: [milter-greylist] config.h included twice - PATCH

2013-08-13 by Jim Klimov

On 2013-08-11 19:03, Jim Klimov wrote:
> On 2013-08-11 16:24, Jim Klimov wrote:
>  > I found some build noise in the milter-greylist compilation like this:
>
> Hmmm... maybe false alarm; at least if you can't reproduce - no
> need to bother then. My build routine keeps the original code
> separate from the generated files, including config.h, and when
> I was applying my patches to a vanilla tarball - I forgot to
> remove the stock config.h, which gave me a number of mismatches
> and errors (it overrode the generated one). Removing it is a
> step I do, and forgot to do, and now I don't have these warnings.

The trivial patch to avoid this conflict is inline below (make
the current directory a higher priority for headers than the
source directory), tested to help on that build system which
did have a problem otherwise.


> Even though the file is still, apparently, included twice... :\

This I did not take care of, so you may want to look into this still...




diff -Naur milter-greylist-4.4.3-orig/Makefile.in 
milter-greylist-4.4.3-jimbuild/Makefile.in
--- milter-greylist-4.4.3-orig/Makefile.in      2013-01-19 
20:01:15.000000000 +0400
+++ milter-greylist-4.4.3-jimbuild/Makefile.in  2013-07-20 
00:07:43.000000000 +0400
@@ -29,7 +29,7 @@
  # OF THE POSSIBILITY OF SUCH DAMAGE.
  #

-CFLAGS=        @CFLAGS@ -D_BSD_SOURCE -I${SRCDIR} -I. @CPPFLAGS@
+CFLAGS=        @CFLAGS@ -D_BSD_SOURCE -I. -I${SRCDIR} @CPPFLAGS@
  LDFLAGS=       @LDFLAGS@
  LIBS=          @LIBS@
  prefix=                @prefix@



HTH,
//Jim

Attachments

Move to quarantaine

This moves the raw source file on disk only. The archive index is not changed automatically, so you still need to run a manual refresh afterward.