Milter-greylist

On 2013-08-12 06:21, manu@... wrote:
> Jim Klimov <jimklimov@... <mailto:jimklimov%40cos.ru>> wrote:
>
>  > So here is a couple of patches: one allows use of "localaddr" by
>  > local_ipstr() for '%V' format string parsing, I believe; its result
>  > can be seen in the X-Greylist headers; and also for p0f which I did
>  > not yet test.
>
> You forgot the bits from conf.c and conf.h. I added them

Huh? I think they are in your patch as well as in mine...

 > and refactored
> the patch a bit. For instance, local_ipstr() never returns NULL,
> therefore there is no need to check it.

So far it doesn't... I did consider it at one point as a cheaper
check than strncmp(), however.

> I also modified %V so that [0.0.0.0] does appear if things are
> misconfigured. That will help admins fixing it.

In this case, the "char* ipstr" is superfluous, and you can keep
the old logic which invoked local_ipstr() right from snprintf().

>
> Here is my version, please tell me if that is fine for you:
> http://ftp.espci.fr/shadow/manu/localaddr.patch

Ok, makes sense - less ambiguities and code-duplication such as in
p0f.c, and (for other readers) this also obsoletes my other recent
"toggle"  milter-greylist-4.4.3-nolog_missing_if_addr.patch

> I checked in your other patch on SPF verbosity.

Thanks :)

//Jim Klimov