Milter-greylist

On 2013-03-23 06:39, Kouhei Sutou wrote:
> Hi,
>  > Kouhei Sutou <kou@... <mailto:kou%40clear-code.com>> wrote:
>  >
>  >> Solutions:
>  >>
>  >> (a) Don't chown() when "socket" parameter value has scheme
>  >> such as "inet", "inet6", "unix" and "local".
>  >> (b) Set "gr" even if "user" parameter value doesn't have
>  >> group. (The attached patch uses this solution.)
>  >>
>  >> I think that we should apply both solutions but I attach
>  >> only (b) solution. Because (b) solves more effected
>  >> problem. "gr" is used other location too. (See
>  >> code around chown(conf.c_pidfile, ...).) (a) doesn't solve
>  >> the problem.
>  >
>  > Right, but you implemented (c), which also has some merit, didn't you?
>  > Or did I miss something?
>  > (c) fail with error message if group cannot be found
>
> Ah, yes. You're right.
> The patch also includes (c). So the patch includes both (b)
> and (c). Sorry for my wrong description.


Hello,

Did you get around to option (a) also? I can confirm that your
patch did solve the crash, even if I don't use "su" to start up
the milter process as unprivileged user now, but the logs still
complain about chowning the socket which is not a filename; this
is a bit "unclean" :)

[ID 945945 mail.warning] /opt/COSmail/bin/milter-greylist:
cannot change "inet:3311@localhost" ownership to mailgrey/mailgrey:
No such file or directory

Thanks,
//Jim