Yahoo Groups archive

Milter-greylist

Index last updated: 2026-04-28 23:32 UTC

Message

Re: [milter-greylist] [PATCH] fix a crash bug by chown socket without group

2013-03-23 by Kouhei Sutou

Hi,

In <1l0608p.1asgwu41srqp32M%manu@...>
  "Re: [milter-greylist] [PATCH] fix a crash bug by chown socket without group" on Sat, 23 Mar 2013 03:01:05 +0100,
  manu@... wrote:

> 
> Kouhei Sutou <kou@...> wrote:
> 
>> Solutions:
>>
>> (a) Don't chown() when "socket" parameter value has scheme
>> such as "inet", "inet6", "unix" and "local".
>> (b) Set "gr" even if "user" parameter value doesn't have
>> group. (The attached patch uses this solution.)
>>
>> I think that we should apply both solutions but I attach
>> only (b) solution. Because (b) solves more effected
>> problem. "gr" is used other location too. (See
>> code around chown(conf.c_pidfile, ...).) (a) doesn't solve
>> the problem.
> 
> Right, but you implemented (c), which also has some merit, didn't you?
> Or did I miss something?
> (c) fail with error message if group cannot be found

Ah, yes. You're right.
The patch also includes (c). So the patch includes both (b)
and (c). Sorry for my wrong description.

Thanks,
--
kou

Attachments

Move to quarantaine

This moves the raw source file on disk only. The archive index is not changed automatically, so you still need to run a manual refresh afterward.