Yahoo Groups archive

Milter-greylist

Index last updated: 2026-04-28 23:32 UTC

Message

Re: [milter-greylist] cannot build rpm on SMP machine

2012-05-17 by Kouhei Sutou

Hi,

In <rmiaa17hf1n.fsf@...>
  "Re: [milter-greylist] cannot build rpm on SMP machine" on Wed, 16 May 2012 19:39:00 -0400,
  Greg Troxel <gdt@...> wrote:

> 
> Kouhei Sutou <kou@...> writes:
> 
>   Here is a patch against milter-greylist itself to support
>   "make -j":
> 
>   --
>   --- Makefile.in.~1.69.~	2012-05-06 15:21:14.000000000 +0900
>   +++ Makefile.in	2012-05-06 15:54:38.921097972 +0900
>   @@ -148,8 +148,14 @@ realclean:	clean
>    .l.c:
>           ${LEX} -o$@ $<
>    .y.c:
>   -	${YACC} -p`echo $@|${SED} 's/^\([^_]\{1,\}_\).*$$/\1/'` $<
>   -	${MV} y.tab.c $@
>   +	prefix=`echo $@|${SED} 's/^\([^_]\{1,\}_\).*$$/\1/'`; \
>   +	${RM} -Rf $${prefix} && \
>   +	${INSTALL} -d $${prefix} && \
>   +	(cd $${prefix} && \
>   +	 ${YACC} -p$${prefix} ../$< && \
>   +	 ${MV} y.tab.c ../$@); \
>   +	${RM} -Rf $${prefix}; \
>   +	${TEST} -f $@
> 
>    # This is a target for debugging
>    start:	milter-greylist
> 
> I don't follow this.  Are you writing to the prefix, or just using
> install for something else.  Can you explain the problem - is it just
> the collision of y.tab.c.  Can't you just use the -o option?  yacc on
> NetBSD supports that, so I suspect it's pretty normal.

The problem is the collision of y.tab.c as you metioned. We
can just use the -o option. But I don't know whether the -o
option is portable. So I wrote the above patch. If we can
assume that yacc on all supported platforms supports the -o
option, I agree with using the -o option.


Thanks,
--
kou

Attachments

Move to quarantaine

This moves the raw source file on disk only. The archive index is not changed automatically, so you still need to run a manual refresh afterward.