Yahoo Groups archive

Milter-greylist

Index last updated: 2026-04-28 23:32 UTC

Message

Re: [milter-greylist] Re: [PATCH] Set CLOEXEC flags for sockets

2010-06-10 by Emmanuel Dreyfus

On Thu, Jun 10, 2010 at 09:54:53AM +0200, Enrico Scholz wrote:
>   socket(_domain, (_type) | SOCK_CLOEXEC, _protocol)
> 
> call is very runtime specific (requires Linux 2.6.27+) and there are
> major Linux distributions which ship older kernels.  Doing a buildtime
> check seems too risky for me.

You worry about binary packages? If they are properly done, they should
take care of that. I don't think anyone should tweak its code to cope with
poor package policies.

We can ifdef SOCK_CLOEXEC, though.

> your decision... I used the socket_cloexec() to generate more efficient
> code (especially when SOCK_CLOEXEC works).

I'm not sure that adding a function call more efficient than using 
a macro.

-- 
Emmanuel Dreyfus
manu@...

Attachments

Move to quarantaine

This moves the raw source file on disk only. The archive index is not changed automatically, so you still need to run a manual refresh afterward.