Yahoo Groups archive

Milter-greylist

Index last updated: 2026-04-28 23:32 UTC

Message

Re: [milter-greylist] "not" keyword no more accepted in compound ACLs ?

2009-09-10 by Benoit Branciard

manu@... a \ufffdcrit :
> Benoit Branciard <benoit.branciard@...> wrote:
> 
>> Digging somewhat further, it appears that the new milter-greylist is 
>> choking on the "not" keyword of an ACL statement, excepted when it is
>> applied to the first clause. 
> 
> Definitively a bug. We'll have to dig the sources...


At first glance, it looks like this is caused by introduction of 
<INITIAL> for the "not" (and like) keywords in conf_lex.l.

The patch below seems to restore the expected behaviour of accepting 
"not" for middle clauses in compound statements. This patch applies to 
stable 4.2.3.

I didn't look very further than testing this patch with my existing 
greylist.conf; I don't know what impact it may have on new features.



--- conf_lex.l.0	2009-09-10 17:03:10.000000000 +0200
+++ conf_lex.l	2009-09-10 17:03:45.000000000 +0200
@@ -190,9 +190,9 @@
  {gt}		{	yylval.op = OP_GT; return OP; }
  {le}		{	yylval.op = OP_LE; return OP; }
  {ge}		{	yylval.op = OP_GE; return OP; }
-<INITIAL>{no}	{ return NO; }
-<INITIAL>{not}	{ return NO; }
-<INITIAL>{neg}	{ return NO; }
+{no}		{ return NO; }
+{not}		{ return NO; }
+{neg}		{ return NO; }
  {prop}		{
  			BEGIN(S_REGEX);
  			strncpy(yylval.prop, yytext, QSTRLEN);



-- 
Benoit BRANCIARD
P\ufffdle Infrastructures
Centre de ressources informatiques et du r\ufffdseau (CRIR)
Universit\ufffd Paris 1 Panth\ufffdon-Sorbonne
http://crir.univ-paris1.fr
Tel. 01 44 07 89 68

-- 
Ce message a ete verifie par MailScanner
pour des virus ou des polluriels et rien de
suspect n'a ete trouve.

Attachments

Move to quarantaine

This moves the raw source file on disk only. The archive index is not changed automatically, so you still need to run a manual refresh afterward.