Yahoo Groups archive

Milter-greylist

Index last updated: 2026-04-28 23:32 UTC

Message

Re: [milter-greylist] [PATCH] support normal user 'make install'

2009-09-04 by Bill Levering

Would it be worth looking for an existing /etc/mail/greylist.conf file  
in the configuration run?
That way NEW installs would be 'a better practice'?

Bill

Bill Levering
idbill@...
KFP: 6C0A 067C 7E03 58C3 C2F7  8278 6DFD 55A8 108B ED2F



On Sep 3, 2009, at 9:29 PM, manu@... wrote:

> Kouhei Sutou <kou@...> wrote:
>
>> I uploaded the same patch to here:
>
> I'm a bit concerned with that:
> CONFFILE="\${SYSCONFDIR}/mail/greylist.conf"
> (...)
> -       ${INSTALL} -d -m 755 ${DESTDIR}/etc/mail
> -       ${TEST} -f ${DESTDIR}/etc/mail/greylist.conf -o         \
> +       ${INSTALL} -d -m 755 ${DESTDIR}`dirname ${CONFFILE}`
>
> So we move from default installation into /etc/mail to
> ${SYSCONFDIR}/mail.
>
> While I agree it is better practice, I beleive this will break some
> setups at upgrade time: without specific configure options, the  
> patched
> milter-greylist is likely to look for its configuration file in
> /usr/local/etc/mail instead of /etc/mail, which is the current  
> behavior.
>
> True, milter-greylist should not use /etc/mail by default, but I'd
> rather not fix this kind of oddities if it is at the price of making
> upgrades more troublesome.
>
> -- 
> Emmanuel Dreyfus
> http://hcpnet.free.fr/pubz
> manu@...
>
>
> ------------------------------------
>
> Yahoo! Groups Links
>
>
>

Attachments

Move to quarantaine

This moves the raw source file on disk only. The archive index is not changed automatically, so you still need to run a manual refresh afterward.