Kouhei Sutou <kou@...> wrote:
> I uploaded the same patch to here:
I'm a bit concerned with that:
CONFFILE="\${SYSCONFDIR}/mail/greylist.conf"
(...)
- ${INSTALL} -d -m 755 ${DESTDIR}/etc/mail
- ${TEST} -f ${DESTDIR}/etc/mail/greylist.conf -o \
+ ${INSTALL} -d -m 755 ${DESTDIR}`dirname ${CONFFILE}`
So we move from default installation into /etc/mail to
${SYSCONFDIR}/mail.
While I agree it is better practice, I beleive this will break some
setups at upgrade time: without specific configure options, the patched
milter-greylist is likely to look for its configuration file in
/usr/local/etc/mail instead of /etc/mail, which is the current behavior.
True, milter-greylist should not use /etc/mail by default, but I'd
rather not fix this kind of oddities if it is at the price of making
upgrades more troublesome.
--
Emmanuel Dreyfus
http://hcpnet.free.fr/pubz
manu@...Message
Re: [milter-greylist] [PATCH] support normal user 'make install'
2009-09-04 by manu@netbsd.org
Attachments
- No local attachments were found for this message.