--- In milter-greylist@yahoogroups.com, "reschauzier" > > Going through the code, it may just be that sr->sr_nmatch in > smtp_reply_free() is not reset properly after a match? > Yes, this indeed turned out to be the case. It is fixed by setting sr->sr_nmatch to zero in smtp_reply_init(). I have uploaded a fix for v4.1.10: http://files.eschauzier.org/milter-greylist/no_autowhite-4.1.10-2.patch Besides the regex change, the file also includes a patch that rolls all of the greylist and autowhite action into a single list, effectively eliminating the autowhitelist. This mod is based on the observation that a tuple entry can only exist in one of the pending and autowhite lists at any given time. Merging the lists into one, practically means that if a greylisted tuple comes in for a second time, the tuple is found in the combined list, after which the type of the entry only needs to change to autowhite (instead of deleting the entry in the pending list, and creating a new entry in the autowhite list). Combining the two lists should give a good performance boost, since milter-greylist only needs to traverse a single list, instead of two, for each message that comes in. Also, since all the files relating the the autowhite list have disappeared, this is one of the rare occasions that the code actually becomes smaller with time ;)
Message
Re: Milter-greylist-4.1.10 segfaults on regular expressions
2009-02-04 by reschauzier
Attachments
- No local attachments were found for this message.