Yahoo Groups archive

Milter-greylist

Index last updated: 2026-04-28 23:32 UTC

Message

Re: [milter-greylist] milter-greylist 4.1.6 is available

2008-09-29 by Greg Troxel

I think this is introduced by Manuel Badzong's contribution. I guess that
if you add a
dacl whitelist default nolog

You'll get it fixed for free. Perhaps the implicit default rules should
always be nolog...

I think the implicit whitelist rule should be nolog - it's not really
news or interesting. I added nolog, and then found that I had to
suppress logging if nolog was set. So even if you don't want to apply
the first hunk, the second is a bugfix - I think your suggestion
wouldn't work without it.


Index: acl.c
===================================================================
RCS file: /milter-greylist/milter-greylist/acl.c,v
retrieving revision 1.81
diff -u -p -r1.81 acl.c
--- acl.c 26 Sep 2008 23:35:44 -0000 1.81
+++ acl.c 29 Sep 2008 14:09:24 -0000
@@ -1953,8 +1953,10 @@ acl_filter(stage, ctx, priv)
/*
* No match: use the default action
*/
- if (testmode || stage == AS_DATA)
+ if (testmode)
retval = EXF_WHITELIST;
+ else if (stage == AS_DATA)
+ retval = EXF_WHITELIST | EXF_NOLOG;
else
retval = EXF_GREYLIST;
retval |= EXF_DEFAULT;
@@ -1963,7 +1965,7 @@ acl_filter(stage, ctx, priv)
priv->priv_sr.sr_autowhite = conf.c_autowhite_validity;
}

- if (retval & EXF_WHITELIST) {
+ if ((retval & EXF_NOLOG) == 0 && retval & EXF_WHITELIST) {
whystr[0] = '\0';
if (retval & EXF_ADDR) {
iptostring(sa, salen, addrstr, sizeof(addrstr));

Attachments

Move to quarantaine

This moves the raw source file on disk only. The archive index is not changed automatically, so you still need to run a manual refresh afterward.