Milter-greylist

On Sun, Sep 28, 2008 at 02:30:26PM +0200, manu@... wrote:
> Here is milter-greylist 4.1.6:
> 
> http://ftp.espci.fr/pub/milter-greylist/milter-greylist-4.1.6.tgz
> MD5 (milter-greylist-4.1.6.tgz) = 654b30650291ecf5bd9cda50e9455f2d
> 
> Changelog since 4.1.5:
>         Fix parse bug for "domain no" clause
>         Spamassassin support (Manuel Badzong)
>         Support for DATA-stage greylisting (Manuel Badzong)
>         Allow syslog facility to be configured (Joe Pruett)
>         Allow logging to be disabled on a per-ACL basis (Joe Pruett)
>         Honour $CPPFLAGS in Makefile (Greg Troxel)
>         p0f support
>         Experimental DKIM support (nobody tested it)
>         libspf2 support in .spec file, for RPM generation (Joe Pruett)
>         status support in Debian startup script (Bernhard Schneider)
> 
> This release contains a nice set of new feature. Please note that DKIM
> is highly experimental, as nobody managed to test it.

	# uname -a
	#
	NetBSD starling.smokva.net 4.0 NetBSD 4.0 (STARLING) #0: Thu Jan 24
	14:30:56 UTC 2008  root@...:/tmp/netbsd/STARLING i386

	# gcc -v
	#
	Using built-in specs.
	Target: i386--netbsdelf
	Configured with: /usr/src/tools/gcc/../../gnu/dist/gcc4/configure
	--enable-long-long --disable-multilib --enable-threads --disable-symvers
	--build=i386-unknown-netbsdelf4.99.3 --host=i386--netbsdelf
	--target=i386--netbsdelf
	Thread model: posix
	gcc version 4.1.2 20061021 prerelease (NetBSD nb3 20061125)

	# ./configure \
	#	--with-user=smmsp \
	#	--enable-dnsrbl \
	#	--with-thread-safe-resolver \
	#	--disable-drac \
	#	--with-libspf_alt=/usr/pkg \
	#	--enable-spamassassin \
	#	--without-libintl-prefix \
	#	--without-libiconv-prefix \
	#	--prefix=/usr/pkg \
	#	--host=i386--netbsdelf \
	#	--mandir=/usr/pkg/man
	#
	(...)

	# make
	#
	gcc -g -O2 -Wall -I/usr/pkg/include -DUSE_SPAMD -DUSE_DNSRBL -D_BSD_SOURCE -I. -I.  -c milter-greylist.c
	gcc -g -O2 -Wall -I/usr/pkg/include -DUSE_SPAMD -DUSE_DNSRBL -D_BSD_SOURCE -I. -I.  -c pending.c
	gcc -g -O2 -Wall -I/usr/pkg/include -DUSE_SPAMD -DUSE_DNSRBL -D_BSD_SOURCE -I. -I.  -c sync.c
	gcc -g -O2 -Wall -I/usr/pkg/include -DUSE_SPAMD -DUSE_DNSRBL -D_BSD_SOURCE -I. -I.  -c dnsrbl.c
	gcc -g -O2 -Wall -I/usr/pkg/include -DUSE_SPAMD -DUSE_DNSRBL -D_BSD_SOURCE -I. -I.  -c list.c
	gcc -g -O2 -Wall -I/usr/pkg/include -DUSE_SPAMD -DUSE_DNSRBL -D_BSD_SOURCE -I. -I.  -c macro.c
	yacc -p`echo conf_yacc.c|sed 's/^\([^_]\{1,\}_\).*$/\1/'` conf_yacc.y
	mv y.tab.c conf_yacc.c
	flex -oconf_lex.c conf_lex.l
	gcc -g -O2 -Wall -I/usr/pkg/include -DUSE_SPAMD -DUSE_DNSRBL -D_BSD_SOURCE -I. -I.  -c conf_yacc.c
	yacc -p`echo dump_yacc.c|sed 's/^\([^_]\{1,\}_\).*$/\1/'` dump_yacc.y
	mv y.tab.c dump_yacc.c
	flex -odump_lex.c dump_lex.l
	gcc -g -O2 -Wall -I/usr/pkg/include -DUSE_SPAMD -DUSE_DNSRBL -D_BSD_SOURCE -I. -I.  -c dump_yacc.c
	gcc -g -O2 -Wall -I/usr/pkg/include -DUSE_SPAMD -DUSE_DNSRBL -D_BSD_SOURCE -I. -I.  -c conf.c
	gcc -g -O2 -Wall -I/usr/pkg/include -DUSE_SPAMD -DUSE_DNSRBL -D_BSD_SOURCE -I. -I.  -c autowhite.c
	gcc -g -O2 -Wall -I/usr/pkg/include -DUSE_SPAMD -DUSE_DNSRBL -D_BSD_SOURCE -I. -I.  -c dump.c
	gcc -g -O2 -Wall -I/usr/pkg/include -DUSE_SPAMD -DUSE_DNSRBL -D_BSD_SOURCE -I. -I.  -c spf.c
	gcc -g -O2 -Wall -I/usr/pkg/include -DUSE_SPAMD -DUSE_DNSRBL -D_BSD_SOURCE -I. -I.  -c acl.c
	gcc -g -O2 -Wall -I/usr/pkg/include -DUSE_SPAMD -DUSE_DNSRBL -D_BSD_SOURCE -I. -I.  -c urlcheck.c
	gcc -g -O2 -Wall -I/usr/pkg/include -DUSE_SPAMD -DUSE_DNSRBL -D_BSD_SOURCE -I. -I.  -c stat.c
	gcc -g -O2 -Wall -I/usr/pkg/include -DUSE_SPAMD -DUSE_DNSRBL -D_BSD_SOURCE -I. -I.  -c clock.c
	gcc -g -O2 -Wall -I/usr/pkg/include -DUSE_SPAMD -DUSE_DNSRBL -D_BSD_SOURCE -I. -I.  -c geoip.c
	gcc -g -O2 -Wall -I/usr/pkg/include -DUSE_SPAMD -DUSE_DNSRBL -D_BSD_SOURCE -I. -I.  -c fd_pool.c
	gcc -g -O2 -Wall -I/usr/pkg/include -DUSE_SPAMD -DUSE_DNSRBL -D_BSD_SOURCE -I. -I.  -c prop.c
	gcc -g -O2 -Wall -I/usr/pkg/include -DUSE_SPAMD -DUSE_DNSRBL -D_BSD_SOURCE -I. -I.  -c ldapcheck.c
	gcc -g -O2 -Wall -I/usr/pkg/include -DUSE_SPAMD -DUSE_DNSRBL -D_BSD_SOURCE -I. -I.  -c dkimcheck.c
	gcc -g -O2 -Wall -I/usr/pkg/include -DUSE_SPAMD -DUSE_DNSRBL -D_BSD_SOURCE -I. -I.  -c p0f.c
	gcc -g -O2 -Wall -I/usr/pkg/include -DUSE_SPAMD -DUSE_DNSRBL -D_BSD_SOURCE -I. -I.  -c spamd.c
	In file included from acl.h:120,
			 from spamd.c:55:
	spf.h:57: error: expected ')' before '*' token
	spf.h:58: error: expected ')' before '*' token
	spf.h:59: error: expected ')' before '*' token
	*** Error code 1

	Stop.
	make: stopped in /tmp/milter-greylist-4.1.6


including spf.h in spamd.c makes it build again, but I don't think that
spamd.c should contain that line:

	# diff -u spamd.c.orig spamd.c
	#
	--- spamd.c.orig        2008-09-29 11:47:41.000000000 +0200
	+++ spamd.c     2008-09-29 11:47:57.000000000 +0200
	@@ -52,6 +52,7 @@
	 #include <sysexits.h>
	 #include <syslog.h>
	 
	+#include "spf.h"
	 #include "acl.h"
	 #include "conf.h"
	 #include "queue.h"


Any ideas? It seems to work on Debian..


Petar