Milter-greylist

On Fri, Sep 26, 2008 at 02:50:07PM +0000, Emmanuel Dreyfus wrote:
> About the code, it looks great, but just one question: why storing the
> socket type as a string? You could use an int for that, whith values
> PF_LOCAL/PF_INET ...

No real reason. It doesn't add complexity and the code stays smaller?


> If you see no problem, I'll rename sa_* stuff into spamd_* (and sa.c into 
> spamd.c), I feel it is more self-describing.

Of course. As I started working on the patch I prefix everything sa_
(SpamAssassin) until SA clashed with a macro in milter-greylist.h. spamd
is definitely the better choice.


> You did not include a license for the two new files... 

Could you paste a BSD License in?


Thanks, Manuel