Milter-greylist

On Fri, Sep 12, 2008 at 05:32:35AM +0200, manu@... wrote:
> Petar Bogdanovic <petar@...> wrote:
> 
> > It only happens when the envelope from contains a `=':
> 
> That chunk of code could be the culprit, in milter-greylist.c. However,
> I have trouble to see where it could be wrong.
> 
>         /*
>          * Strip anything before the last '=' in the
>          * source address. This avoid problems with
>          * mailing lists using a unique sender address
>          * for each retry.
>          */
>         if ((idx = rindex(tmpfrom, '=')) == NULL)
>                 idx = tmpfrom; 

Erm, maybe it's too early and I don't see what you see, but this
actually is the problem.

I did a quick test with:

	- if ((idx = rindex(tmpfrom, '=')) == NULL)
	+ /* if ((idx = rindex(tmpfrom, '=')) == NULL) */
		idx = tmpfrom;

and it worked:

	milter-greylist: (unknown id): skipping greylist because recipient <petar@...> is whitelisted,
	(from=<listname+user=domain.tld@...>, rcpt=<petar@...>, addr=localhost[127.0.0.1])
	      ^^^^^^^Y^^^^^^
	      (missing part)


It's obvious however that this will cause troubles when -- as the
comment block states -- ``mailing lists use a unique sender address
for each retry''.


Thanks,

Petar