Yahoo Groups archive

Milter-greylist

Index last updated: 2026-04-28 23:32 UTC

Message

Re: [milter-greylist] milter-greylist 4.0 alpha6 is available

2007-06-15 by Fabien Tassin

damn yahoo. retry without the patch.

http://www.sofaraway.org/tmp/milter-greylist/milter-greylist-4.0a6-configure.patch

/Fabien

===
Date: Fri, 15 Jun 2007 11:47:27 +0200
From: Fabien Tassin <fta+miltergreylist@...>
To: milter-greylist@yahoogroups.com
Subject: Re: [milter-greylist] milter-greylist 4.0 alpha6 is available

According to Fabien Tassin:
> According to manu@...:
> > Fabien Tassin <fta+miltergreylist@...> wrote:
> > 
> > > Just had a look. Seems easy but current code is a little bit messy.
> > > Some tests are performed twice, and lib tests are spread everywhere.
> > > Would you accept a patch that moves blocs around ?
> > > (I know some reject that considering it's cosmetic).
> > 
> > Well, let's hope that won't break everything...
> > 
> > > I'd like to add a few comments in there too (1 line explaining what the
> > > next bloc is about). Do you mind ?
> > 
> > Go ahead.

done.

I haven't merged the tests as I said I would as it makes the code
unnecessarily complex.

What I did is:
- reordered everything so that all tests are now grouped by feature
- added real checks for libcurl, libgeoip and berkeley db
- added support for --with-package in addition to the already existing
  --with-package=DIR
- added a few comments
- re-aligned --help message
- added an additional test for libmilter on debian/ubuntu using
  /usr/lib/libmilter as it is not possible to use --with-libmilter=DIR
  because it end up with /usr/lib/libmilter/lib/libmilter.so (no good).
  [ I'm not sure it's not a bug in those distro. I've opened a case
    on Ubuntu to check ]

remaining:
- real check for drac. really useful ? seems drac in m-g is only a db lookup
so it only has to to test berkeley db. correct ?
- --with-geoip-db=PATH similar to --with-drac-db=PATH

I've tested tons of situations and it seems ok.

/Fabien

Attachments

Move to quarantaine

This moves the raw source file on disk only. The archive index is not changed automatically, so you still need to run a manual refresh afterward.