Milter-greylist

On Fri, May 04, 2007 at 01:57:46PM +0200, Michael Fromme wrote:
> searching for a reason I found the dnsrbl_list_cleanup function
> of dnsrbl.c which is not called anywhere (?)
> 
> A place would be real_close, just before free(priv) like
> #ifdef USE_DNSRBL
> 		dnsrbl_list_cleanup(priv);
> #endif

Indeed you found a memory leak.

> Is the dnsrbl list bound to a single email - or am I
> missing something here? 

Yes, the goal is to avoid multiple DNS requests when the same DNSRBL
is used in several ACL lines.

> DNSBL lookups may take time, and
> it's a good idea to keep knowledge for let's say an hour.

I'm not sure it's interesting to build a cache system: you can 
have a local DNS on your machine to make the lookups faster, and that
local DNS will respect the TTL set by the DNSRBL publisher.

-- 
Emmanuel Dreyfus
manu@...