Yahoo Groups archive

Milter-greylist

Index last updated: 2026-04-28 23:32 UTC

Message

Re: [milter-greylist] I broke X-Greylist header

2007-04-15 by AIDA Shinra

At Sat, 14 Apr 2007 21:27:19 +0200,
manu@... wrote:
> 
> AIDA Shinra <shinra@...> wrote:
> 
> > Sorry, I broke X-Greylist header when a mail is greylisted and passed:
> > http://www.j10n.org/files/mgl-20070407-x-greylist.patch
> 
> Why does that comment has to go away?
>         /*
> -        * On a multi-recipient message, one message can be whitelisted,
> -        * and the next ones be greylisted. The first one would
> -        * pass through immediatly (priv->priv_sr.sr_delay = 0) with a
> -        * priv->priv_sr.sr_whitelist = EXF_NONE. This would cause improper
> -        * X-Greylist header display in mlfi_eom()
> -        *
> -        * The fix: if we make it to mlfi_eom() with priv_sr.sr_elapsed = 0
> -        * this means that some recipients were whitelisted.
> -        * We can set priv_sr.sr_whitelist now, because if the message
> -        * is greylisted for everyone, it will not go to mlfi_eom(),
> -        * and priv_sr.sr_whitelist will not be used.
> -        */

I missed a point. I focused when a recipient is whitelisted and another
is ACCEPTED after greylisting. The above code focuses when a recipient
is whitelisted and another is GOING TO BE DELAYED.

Anyway, the above code do not work when a recipient is whitelisted
and another is BLACKLISTED. What about this code?

http://www.j10n.org/files/mgl-20070407-x-greylist-revised.patch

Attachments

Move to quarantaine

This moves the raw source file on disk only. The archive index is not changed automatically, so you still need to run a manual refresh afterward.