Yahoo Groups archive

Milter-greylist

Index last updated: 2026-04-28 23:32 UTC

Message

Re: [milter-greylist] SPF breakage

2007-03-22 by AIDA Shinra

At Thu, 22 Mar 2007 10:16:53 +0000,
Emmanuel Dreyfus wrote:
> 
> On Thu, Mar 22, 2007 at 12:10:57PM +0200, Mart Pirita wrote:
> > Prr, seems I have old and noncompatible cvs for that job:(.
> 
> Perhaps export CVS_RSH=ssh ?
> 
> 3.1.8 contains the fix, anyway.

Real fix here:

Index: milter-greylist.c
===================================================================
RCS file: /milter-greylist/milter-greylist/milter-greylist.c,v
retrieving revision 1.179
diff -u -r1.179 milter-greylist.c
--- milter-greylist.c	22 Mar 2007 16:28:52 -0000	1.179
+++ milter-greylist.c	22 Mar 2007 11:35:46 -0000
@@ -415,7 +415,7 @@
 	/*
 	 * Is the sender address SPF-compliant?
 	 */
-	if ((conf.c_nospf == 0) && (SPF_CHECK(priv) != EXF_NONE)) {
+	if ((conf.c_nospf == 0) && SPF_CHECK(priv)) {
 		char ipstr[IPADDRSTRLEN];
 
 		if (iptostring(SA(&priv->priv_addr),
Index: spf.h
===================================================================
RCS file: /milter-greylist/milter-greylist/spf.h,v
retrieving revision 1.12
diff -u -r1.12 spf.h
--- spf.h	9 Jan 2007 22:22:43 -0000	1.12
+++ spf.h	22 Mar 2007 11:35:46 -0000
@@ -47,7 +47,7 @@
 		  struct acl_param *, struct mlfi_priv *);
 #define SPF_CHECK(priv) spf_check(NULL, AS_RCPT, NULL, (priv))
 #else
-#define SPF_CHECK(priv) EXF_NONE
+#define SPF_CHECK(priv) 0
 
 #endif

Attachments

Move to quarantaine

This moves the raw source file on disk only. The archive index is not changed automatically, so you still need to run a manual refresh afterward.