Milter-greylist

Hi,

>>> Fri, 06 Oct 2006 02:07:34 +0900,
>>> Hajimu UMEMOTO <ume@...> said:

ume> I could reproduce it on my 4.11-STABLE box.  It is rather name space
ume> problem in FreeBSD 4.X and earlier, and sys/types.h shouldn't be
ume> required on most systems which are standard compliant.  But, including
ume> sys/types.h should be harmless.

macro.c includes sys/types.h already but after inclusion of regex.h.
Please use this patch, instead.  It suppresses following warnings as
well:

In file included from milter-greylist.h:36,
                  from macro.c:56:
/usr/include/arpa/inet.h:89: warning: parameter has incomplete type
/usr/include/arpa/inet.h:92: warning: parameter has incomplete type
/usr/include/arpa/inet.h:96: warning: parameter has incomplete type

Index: macro.c
diff -u -p macro.c.orig macro.c
--- macro.c.orig	Tue Sep  5 07:25:29 2006
+++ macro.c	Fri Oct  6 02:12:19 2006
@@ -38,6 +38,7 @@ __RCSID("$Id: macro.c,v 1.1.2.1 2006/09/
 #endif
 #endif
 
+#include <sys/types.h>
 #include <stdio.h>
 #include <stdlib.h>
 #include <string.h>
@@ -51,7 +52,6 @@ __RCSID("$Id: macro.c,v 1.1.2.1 2006/09/
 #else 
 #include <sys/queue.h>
 #endif
-#include <sys/types.h>
 
 #include "milter-greylist.h"
 #include "pending.h"
Index: milter-greylist.h
diff -u milter-greylist.h.orig milter-greylist.h
--- milter-greylist.h.orig	Tue Sep  5 07:05:59 2006
+++ milter-greylist.h	Fri Oct  6 02:16:11 2006
@@ -33,8 +33,8 @@
 #define _MILTER_GREYLIST_H_
 
 #include <sys/socket.h>
-#include <arpa/inet.h>
 #include <netinet/in.h>
+#include <arpa/inet.h>
 #include <netdb.h>
 
 #include <libmilter/mfapi.h>

Sincerely,

--
Hajimu UMEMOTO @ Internet Mutual Aid Society Yokohama, Japan
ume@...  ume@{,jp.}FreeBSD.org
http://www.imasy.org/~ume/