Yahoo Groups archive

Milter-greylist

Index last updated: 2026-04-28 23:32 UTC

Message

RE: [milter-greylist] milter-greylist 3.0rc2 is out

2006-09-26 by attila.bruncsak@itu.int

> 
> http://ftp.espci.fr/pub/milter-greylist/milter-greylist-3.0rc2.tgz
> MD5 (milter-greylist-3.0rc2.tgz) = 445604a69f90647ad4438bbc9c1d362e 
> 
> Changes since rc1:
>         Honour LINE_MAX for syslog (Attila Bruncsak)
>         fix MX sync again on Tru64 (Attila Bruncsak)
> 

Hello,

Emmanuel, why have you changed again the line 
   syslog(level, "%s", messagebuffer);
to
  syslog(level, messagebug);
?

The man syslog(3) says:

>  void syslog(
>          int priority,
>          const char *format,...);

So syslog(3) requires a format string.
The messagebug/messagebuffer already contains a formatted string as a result of the previous vsnprintf.

If there would be an e-mail address like rr%ss@... to be printed literally, the syslog would look for an additional non-existent argument incorrectly.

The "%s" is a must there.

On the other hand there is still a bit of confusion on the name of the buffer, so it does not even compile.

Bests,
Attila

Attachments

Move to quarantaine

This moves the raw source file on disk only. The archive index is not changed automatically, so you still need to run a manual refresh afterward.