Yahoo Groups archive

Milter-greylist

Index last updated: 2026-04-28 23:32 UTC

Message

Re: [milter-greylist] milter-greylist 2.1.8 is available

2006-07-29 by Hajimu UMEMOTO

Hi,

>>>>> On Fri, 28 Jul 2006 14:58:41 +0000
>>>>> Emmanuel Dreyfus <manu@...> said:

manu> At mine the milter is unstable (2.1.8 plus your patches. It was also unstable
manu> at 2.1.8). I think there is a corrupted memory issue. Here is a header that
manu> was generated:
manu> Sender IP whitelisted, not delayed by milter-greylist-2.1.9a1 (mx2.espci.fr [193.54.82.18]); Fri, 28 Jul 2006 16:53:17 +0200 (\232\265(\001\325KpA\226z\210A\211\202\024\001\325Q\253\001\325Q\020A\20710 )

manu> Reading the code, it's not the string generation, it must be more widespread.

manu> If you find something wrong...

I'm not sure if this patch solves your problem, it seems res must be
initialized before calling memset().

Index: dnsrbl.c
diff -u -p dnsrbl.c.orig dnsrbl.c
--- dnsrbl.c.orig	Sat Jul 29 00:41:51 2006
+++ dnsrbl.c	Sun Jul 30 04:27:23 2006
@@ -103,6 +103,9 @@ dnsrbl_check_source(sa, salen, source)
 
 	blacklisted = SA(&source->d_blacklisted);
 
+#ifdef HAVE_RESN
+	memset(&res, 0, sizeof(res));
+#endif
 	res_ninit(&res);
 
 	reverse_endian(SA(&ss), sa);


Sincerely,

--
Hajimu UMEMOTO @ Internet Mutual Aid Society Yokohama, Japan
ume@...  ume@{,jp.}FreeBSD.org
http://www.imasy.org/~ume/

Attachments

Move to quarantaine

This moves the raw source file on disk only. The archive index is not changed automatically, so you still need to run a manual refresh afterward.