Milter-greylist

Hi,

>>>>> On Fri, 28 Jul 2006 14:58:41 +0000
>>>>> Emmanuel Dreyfus <manu@...> said:

manu> On Fri, Jul 28, 2006 at 08:54:56PM +0900, Hajimu UMEMOTO wrote:
> Umm, it seems the reson string in X-Greylist: header is strange:
> 
> 	X-Greylist: Internal error , not delayed by milter-greylist-2.1.8
> 	 (ameno.mahoroba.org [218.45.22.175]); Fri, 28 Jul 2006 20:32:00
> 	 +0900 (JST)
> 
> I'm testing it with following configuration:
> 
> 	dnsrbl "MAHOROBA DNSWL" dnswl.mahoroba.org 127.0.0.10
> 	acl whitelist dnsrbl "MAHOROBA DNSWL"

I found the cause.  The reason strings were not set.  Here is a patch:

Index: acl.c
diff -u -p acl.c.orig acl.c
--- acl.c.orig	Fri Jul 28 05:08:32 2006
+++ acl.c	Sat Jul 29 00:12:06 2006
@@ -691,6 +691,12 @@ acl_filter(sa, salen, hostname, from, rc
 			iptostring(sa, salen, addrstr, sizeof(addrstr));
 			snprintf(tmpstr, sizeof(tmpstr),
 			     "address %s is whitelisted", addrstr);
+			ADD_REASON(whystr, tmpstr);
+		}
+		if (retval & EXF_DNSRBL) {
+			iptostring(sa, salen, addrstr, sizeof(addrstr));
+			snprintf(tmpstr, sizeof(tmpstr),
+			     "address %s is whitelisted by DNSRBL", addrstr);
 			ADD_REASON(whystr, tmpstr);
 		}
 		if (retval & EXF_DOMAIN) {
Index: milter-greylist.c
diff -u -p milter-greylist.c.orig milter-greylist.c
--- milter-greylist.c.orig	Fri Jul 28 05:08:32 2006
+++ milter-greylist.c	Sat Jul 29 00:23:20 2006
@@ -572,6 +572,10 @@ mlfi_eom(ctx)
 			ADD_REASON(whystr, "IP, sender and recipient auto-whitelisted");
 			priv->priv_whitelist &= ~EXF_AUTO;
 		}
+		if (priv->priv_whitelist & EXF_DNSRBL) {
+			ADD_REASON(whystr, "Sender IP whitelisted by DNSRBL");
+			priv->priv_whitelist &= ~EXF_DNSRBL;
+		}
 		if (priv->priv_whitelist & EXF_DEFAULT) {
 			ADD_REASON(whystr, "Default is to whitelist mail");
 			priv->priv_whitelist &= ~EXF_DEFAULT;


manu> At mine the milter is unstable (2.1.8 plus your patches. It was also unstable
manu> at 2.1.8). I think there is a corrupted memory issue. Here is a header that
manu> was generated:
manu> Sender IP whitelisted, not delayed by milter-greylist-2.1.9a1 (mx2.espci.fr [193.54.82.18]); Fri, 28 Jul 2006 16:53:17 +0200 (\232\265(\001\325KpA\226z\210A\211\202\024\001\325Q\253\001\325Q\020A\20710 )

manu> Reading the code, it's not the string generation, it must be more widespread.

Perhaps, it is another issue I didn't met yet.

Sincerely,

--
Hajimu UMEMOTO @ Internet Mutual Aid Society Yokohama, Japan
ume@...  ume@{,jp.}FreeBSD.org
http://www.imasy.org/~ume/