Yahoo Groups archive

Milter-greylist

Index last updated: 2026-04-28 23:32 UTC

Message

domaincmp(), acl.c, acl whitelist domain matching

2006-06-15 by pinkworld4me

Is it the intended behavior for domaincmp() to only match the end of a
domain?  For example, we had to whitelist ey.com for Ernst & Young,
and  domains like monkey.com and grimey.com, etc., also get whitelisted.

Shouldn't the functionality be that the full domain should match?
If subdomains are supposed to match, then a dot should be added at the
start of host and domain variables in domaincmp() before the
comparison is done.

If this is not the intended behavior, then one possible fix is to add
the code:
        if (hidx >= 0)
                return (0);

after to the current code:
        if (didx >= 0)
                return (0);

I have not tried/tested this yet.

Attachments

Move to quarantaine

This moves the raw source file on disk only. The archive index is not changed automatically, so you still need to run a manual refresh afterward.