Milter-greylist

--- In milter-greylist@yahoogroups.com, Emmanuel Dreyfus <manu@...> wrote:
>
> On Tue, Jun 06, 2006 at 02:33:42PM -0000, Ugo Bellavance wrote:
> >
http://www.snert.com/Software/ecartis/index.php?go=/milters/2006-06/959
> > and, if possible, correct the situation.
> 
> The m4 file was contributed by Ivan F. Martinez. I must confess I
never used
> it, so I cannot judge if it is harmful or not.

Understood.

> The README file clearly enumerates what macro should be defined and
why. 
> milter-greylist does not require other macros to be removed, it just
require
> some macros to be defined. The m4 file define the nescessary macros.
> 
> If the m4 file cause unnescessary macros to be removed, then yes, it
can 
> be harmful for other milters. But I don't agree on calling this a bug: 
> the documentation just claim that the m4 file will make sendmail working
> with milter-greylist, it says nothing about Anthony Howe's software 
> requirements (does it really crash, BTW? That would mean it lacks a 
> basic sanity check when reading macros)

I didn't see it crash.  In my case, it was just not working.  If you
want to see the requirement for the milter:
http://www.snertsoft.com/sendmail/milter-sender/

> Any m4 expert here to improve that m4 file so that it just adds macros
> and don't remove any? If there is a pitfall here it would be nice to 
> improve things so that users cannot fall into it.

Little precision:  This is not only a sendmail-greylist.m4 file issue.
 If I manually add what is said in the README file and delete the
milter-greylist.m4 file, the problem is still there.

INPUT_MAIL_FILTER(`greylist',
`S=local:/var/milter-greylist/milter-greylist.sock')
define(`confMILTER_MACROS_CONNECT', `j, {if_addr}')
define(`confMILTER_MACROS_HELO', `{verify}, {cert_subject}')
define(`confMILTER_MACROS_ENVFROM', `i, {auth_authen}')
define(`confMILTER_MACROS_ENVRCPT', `{greylist}')

I didn't try adding the entries directly into sendmail.cf, I never
edit the .cf file directly.  If you do require people to edit the .cf
file directly, you will loose most of your users.

According to Howe, the define() statements replace the previous
values, overriding values needed by other software.

Thanks,
Ugo Bellavance
PS: I don't want to start a war between 2 developpers, I just want to
help you both, and make it possible & easy for your software to co-exist.